domain: run FLUSH PRIVILEGES synchronous on GRANT#8886
Merged
morgo merged 2 commits intopingcap:masterfrom Dec 31, 2018
morgo:flush
Merged
domain: run FLUSH PRIVILEGES synchronous on GRANT#8886morgo merged 2 commits intopingcap:masterfrom morgo:flush
morgo merged 2 commits intopingcap:masterfrom
morgo:flush
Conversation
MySQL compatible behavior.
Contributor
Author
|
/run-all-tests |
Contributor
|
LGTM |
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
MySQL compatible behavior.
ngaut
pushed a commit
that referenced
this pull request
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #8427
What is changed and how it works?
When a
GRANT,DROP USER,CREATE USERis run, TiDB will asynchronously notify peers via etcd. The problem is that for the test suite, mocktikv (and MySQL compatibility) it is required to runFLUSH PRIVILEGESsynchronously. This is because changes are expected to apply immediately.Check List
Tests
Code changes
Side effects
FLUSH PRIVILEGESwhen it receives the etcd notification)Related changes
This change is