planner: refine PhysicalProjection.ResolveIndices during neighbouring Proj#8073
Merged
zz-jason merged 9 commits intopingcap:masterfrom Nov 2, 2018
Merged
planner: refine PhysicalProjection.ResolveIndices during neighbouring Proj#8073zz-jason merged 9 commits intopingcap:masterfrom
zz-jason merged 9 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
PTAL @zz-jason |
Member
|
@XuHuaiyu Please fill the description and add a unit test. |
winoros
reviewed
Oct 27, 2018
00ac877 to
2c9aa76
Compare
Contributor
Author
Contributor
Author
|
/run-all-tests |
winoros
reviewed
Oct 29, 2018
alivxxx
reviewed
Oct 29, 2018
zz-jason
reviewed
Nov 1, 2018
Contributor
Author
Contributor
Author
|
/run-all-tests |
winoros
reviewed
Nov 1, 2018
Contributor
Author
Contributor
Author
|
/run-all-tests |
Member
|
@XuHuaiyu Please cherrypick this bugfix to the release-2.0 and release-2.1 branch. |
zz-jason
pushed a commit
that referenced
this pull request
Nov 2, 2018
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 2, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 5, 2018
13 tasks
This was referenced Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and test to be added.
What problem does this PR solve?
Before this PR, this query will cause a panic.
What is changed and how it works?
explain info:
After buildProjection4Union,
Projection_21:test.t1.a.IndexandProjection_21:test.t1.c.Indexwill be 0 and 1 individually.While both the two
Projection_22.test.t1.a.Indexare 0.Thus during execution, when
Projection_21:test.t1.ccalling chunk.SwapColumn, it will get an empty chunk.column, which would cause the panic.Check List
Tests
Code changes
Side effects
Related changes
release-2.1 release-2.0