Skip to content

Retry transaction without for update#79

Merged
shenli merged 11 commits intomasterfrom
ngaut/txn-retry
Sep 9, 2015
Merged

Retry transaction without for update#79
shenli merged 11 commits intomasterfrom
ngaut/txn-retry

Conversation

@ngaut
Copy link
Member

@ngaut ngaut commented Sep 9, 2015

No description provided.

Support query like: set a=a+1
Make sure we do not retry "select for update statement"
Support query like: set a=a+1
Make sure we do not retry "select for update statement"
Conflicts:
	sessionctx/forupdate/for_update_ctx.go
@coocood
Copy link
Member

coocood commented Sep 9, 2015

It seems like "ForUpdate" is never reset. If user executed an "FoUpdate" transaction, then the following transactions would be always "ForUpdate".

Reset statement history
@ngaut
Copy link
Member Author

ngaut commented Sep 9, 2015

PTAL

session.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.history.reset()?

@coocood
Copy link
Member

coocood commented Sep 9, 2015

LGTM

1 similar comment
@shenli
Copy link
Member

shenli commented Sep 9, 2015

LGTM

shenli added a commit that referenced this pull request Sep 9, 2015
Retry transaction without for update
@shenli shenli merged commit bed459a into master Sep 9, 2015
@ngaut ngaut deleted the ngaut/txn-retry branch September 14, 2015 06:32
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
* *: replaced juju/errors by pingcap/errors and use builtin context package

* vendor: update tidb to v2.1.0-rc.3 and update its dependencies

* vendor: update the rest of the direct dependencies

* license: added commercial license

* vendor: update TiDB and PD to v2.1.0-rc.4

Removed the goyacc step since the parser has been moved out. For now we
rely on `git checkout` to recover the parser until v3.0.0-alpha is tagged

* tests: reduce the number of max-open-files used by tikv-server

Jenkin's open file limit is somehow reduced to 65536, and the default tikv
requirement is 40960*2+1000 = 82920, causing CI failing to start the
integration tests. Here we reduce the number to 4096*2+1000 = 9192 via
explicit config.

* license: fix the year range
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
Defined2014 added a commit to Defined2014/tidb that referenced this pull request Apr 28, 2022
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Oct 31, 2022
Signed-off-by: ystaticy <y_static_y@sina.com>
nolouch pushed a commit to tidblabs/tidb that referenced this pull request Jan 6, 2023
…ap#144 into keyspace on release 6.4  (pingcap#161)

* Merge PR pingcap#78,pingcap#79,pingcap#82,pingcap#83,pingcap#86,pingcap#144 into keyspace on release 6.4

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix error

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix comment

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
crazycs520 pushed a commit that referenced this pull request Oct 13, 2025
https://e.gitee.com/pingcap_enterprise/repos/pingcap_enterprise/tidb/pulls/378
Co-authored-by: joccau <zak.zhao@pingcap.cn>
Reviewed-on: https://git.pingcap.net/pingkai/tidb/pulls/79
Reviewed-by: wink.yao <wink.yao@pingcap.cn>
Co-authored-by: tianyuan <tianyuan@pingcap.cn>
Co-committed-by: tianyuan <tianyuan@pingcap.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants