Skip to content

log backup: use global checkpoint ts as source of truth (#58135) (#59061) | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944#64033

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5-20241112-v6.5.11from
3pointer:pick_to_hotfix
Oct 20, 2025
Merged

log backup: use global checkpoint ts as source of truth (#58135) (#59061) | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944#64033
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5-20241112-v6.5.11from
3pointer:pick_to_hotfix

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Oct 18, 2025

What problem does this PR solve?

Issue Number: close #58031

What changed and how does it work?

pick #58135 to hotfix

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 18, 2025
@tiprow
Copy link

tiprow bot commented Oct 18, 2025

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor Author

3pointer commented Oct 18, 2025

/hold for #64032 merge first

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2025
@3pointer 3pointer changed the title log backup: use global checkpoint ts as source of truth (#58135) (#59061) log backup: use global checkpoint ts as source of truth (#58135) (#59061) | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944 Oct 18, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2025
@3pointer
Copy link
Contributor Author

3pointer commented Oct 20, 2025

/retest

@tiprow
Copy link

tiprow bot commented Oct 20, 2025

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-6.5-20241112-v6.5.11@563e42b). Learn more about missing BASE report.

Additional details and impacted files 
@@                        Coverage Diff                        @@
##             release-6.5-20241112-v6.5.11     #64033   +/-   ##
=================================================================
  Coverage                                ?   73.6187%           
=================================================================
  Files                                   ?       1097           
  Lines                                   ?     353004           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     259877           
  Misses                                  ?      76403           
  Partials                                ?      16724
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-18 12:10:39.843930903 +0000 UTC m=+528145.921183463: ☑️ agreed by Leavrth.
  • 2025-10-20 06:02:28.881284774 +0000 UTC m=+678854.958537324: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2025
@3pointer
Copy link
Contributor Author

3pointer commented Oct 20, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 4f24620 into pingcap:release-6.5-20241112-v6.5.11 Oct 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@Leavrth Leavrth Leavrth approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@3pointer @YuJuncen @Leavrth @BornChanger @ti-chi-bot