Skip to content

log backup: set a proper maxVersion to resolve lock#57178

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
3pointer:issue_57134
Nov 11, 2024
Merged

log backup: set a proper maxVersion to resolve lock#57178
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
3pointer:issue_57134

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Nov 6, 2024

What problem does this PR solve?

Issue Number: close #57134

Problem Summary:

  1. See issue.

What changed and how does it work?

To minimize the risk of lock conflicts, set the maxVersion to be the largest existing version value across all slow regions, incremented by 1. This adjustment helps optimize RPO by proactively reducing lock contention.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2024
@tiprow
Copy link

tiprow bot commented Nov 6, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8203%. Comparing base (87669fb) to head (7e8d4c4).
Report is 126 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57178        +/-   ##
================================================
+ Coverage   73.0633%   74.8203%   +1.7569%     
================================================
  Files          1659       1705        +46     
  Lines        458027     468795     +10768     
================================================
+ Hits         334650     350754     +16104     
+ Misses       102843      96141      -6702     
- Partials      20534      21900      +1366
Flag Coverage Δ
integration 49.3121% <0.0000%> (?)
unit 72.3731% <100.0000%> (+0.0365%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (-0.1806%) ⬇️
parser ∅ <ø> (∅)
br 61.0989% <100.0000%> (+15.3786%) ⬆️
---- 🚨 Try these New Features:

YuJuncen
YuJuncen approved these changes Nov 7, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
3pointer and others added 2 commits November 7, 2024 13:23
@3pointer @YuJuncen
Update br/pkg/streamhelper/basic_lib_for_test.go
a803fd4 
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@BornChanger
Update basic_lib_for_test.go
7e8d4c4
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 02:45:48.07396117 +0000 UTC m=+1095460.913116709: ☑️ agreed by YuJuncen.
  • 2024-11-11 01:54:42.631941205 +0000 UTC m=+234844.822810198: ☑️ agreed by BornChanger.

@BornChanger
Copy link
Contributor

BornChanger commented Nov 11, 2024

/retest

@tiprow
Copy link

tiprow bot commented Nov 11, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 042846e into pingcap:master Nov 11, 2024
@3pointer 3pointer added type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot removed type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 11, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

@3pointer: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

Details

In response to adding label named type/cherry-pick-for-release-6.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

@3pointer: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

Details

In response to adding label named type/cherry-pick-for-release-7.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

@3pointer: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

Details

In response to adding label named type/cherry-pick-for-release-8.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3pointer 3pointer added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 11, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2024

In response to a cherrypick label: new pull request created to branch release-6.5: #57278.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#57178
5c21d10 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #57279.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2024

In response to a cherrypick label: new pull request created to branch release-7.1: #57280.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#57178
c60d046 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #57281.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#57178
c5d8811 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
@D3Hunter D3Hunter mentioned this pull request Nov 11, 2024
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Nov 11, 2024
@ti-chi-bot
log backup: set a proper maxVersion to resolve lock (#57178) (#57280)
051f12c 
close #57134
@3pointer 3pointer added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 21, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #57598.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 21, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 22, 2024
@ti-chi-bot
log backup: set a proper maxVersion to resolve lock (#57178) (#57598)
5c55cb4 
close #57134
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
log backup: set a proper maxVersion to resolve lock (#57178) (#57281)
ecea3b6 
close #57134
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
log backup: set a proper maxVersion to resolve lock (#57178) (#57279)
db9a6b9 
close #57134
ti-chi-bot bot pushed a commit that referenced this pull request Feb 13, 2025
@ti-chi-bot
log backup: set a proper maxVersion to resolve lock (#57178) (#57278)
57b9e4b 
close #57134
3pointer pushed a commit to 3pointer/tidb that referenced this pull request Oct 18, 2025
@ti-chi-bot @3pointer
log backup: set a proper maxVersion to resolve lock (pingcap#57178) (p…
aeb7b62 
…ingcap#57278)

close pingcap#57134
@3pointer 3pointer mentioned this pull request Oct 18, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 20, 2025
@3pointer
log backup: set a proper maxVersion to resolve lock (#57178) (#57278) (…
563e42b 
…#64032)

close #57134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Log Backup: Advancer cannot resolve lock when memory lock is not nil.

5 participants

@3pointer @BornChanger @ti-chi-bot @YuJuncen @D3Hunter