executor: introduce max_user_connections | tidb-test=pr/2474 by joccau · Pull Request #59197 · pingcap/tidb

joccau · 2025-01-24T09:08:47Z

What problem does this PR solve?

Issue Number: Close #59203

Problem Summary: TiDB can support the feature of max_use_connections.

What changed and how does it work?

TiDB supports max_user_connections to limit the login count when login tidb-server.
- Introduction of the System Variable MAX_USER_CONNECTIONS
- A new field max_user_connections is added into system table mysql.user.
- Check user connections when login in TiDB-server.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

integration test case

https://github.com/PingCAP-QE/tidb-test/pull/2474

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiDB supports max_user_connections to limits the login count.

… to community tidb. Signed-off-by: joccau <zak.zhao@pingcap.cn>

Signed-off-by: joccau <zak.zhao@pingcap.cn>

…ions

Signed-off-by: joccau <zak.zhao@pingcap.cn>

codecov · 2025-02-06T08:42:14Z

Codecov Report

Attention: Patch coverage is 72.19251% with 52 lines in your changes missing coverage. Please review.

Project coverage is 74.7743%. Comparing base (87f6782) to head (141595a).
Report is 9 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59197        +/-   ##
================================================
+ Coverage   72.9647%   74.7743%   +1.8096%     
================================================
  Files          1697       1715        +18     
  Lines        468950     470704      +1754     
================================================
+ Hits         342168     351966      +9798     
+ Misses       105711      96983      -8728     
- Partials      21071      21755       +684

Flag	Coverage Δ
integration	`46.3377% <54.8022%> (?)`
unit	`72.3266% <72.1925%> (+0.1557%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`61.4663% <ø> (+16.3499%)`	⬆️

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau · 2025-02-07T07:47:57Z

/test unit-test

tiprow · 2025-02-07T07:48:07Z

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: joccau <zak.zhao@pingcap.cn>

…ge of 'create user'. Signed-off-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot · 2025-02-25T04:17:24Z

[LGTM Timeline notifier]

Timeline:

2025-02-24 09:52:08.309273099 +0000 UTC m=+263076.262431377: ☑️ agreed by D3Hunter.
2025-02-25 04:17:23.662093098 +0000 UTC m=+329391.615251363: ☑️ agreed by bb7133.

joccau · 2025-02-25T04:22:53Z

/test unit-test

tiprow · 2025-02-25T04:22:59Z

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joccau · 2025-02-25T04:40:25Z

/test tidb_parser_test

ti-chi-bot · 2025-02-25T04:40:28Z

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-scan-deps

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

Details

In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-02-25T04:40:50Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-scan-deps
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joccau · 2025-02-25T05:01:19Z

/test check-dev2

tiprow · 2025-02-25T05:01:24Z

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

BornChanger

br part lgtm

joccau · 2025-02-25T05:45:11Z

/cc @benmeadowcroft

ti-chi-bot · 2025-02-25T05:45:13Z

@joccau: GitHub didn't allow me to request PR reviews from the following users: BenMeadowcroft.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joccau · 2025-02-25T05:48:07Z

/cc @benmeadowcroft

ti-chi-bot · 2025-02-25T05:48:10Z

@joccau: GitHub didn't allow me to request PR reviews from the following users: BenMeadowcroft.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joccau · 2025-02-25T05:49:15Z

/cc @yudongusa

ti-chi-bot · 2025-02-25T05:49:17Z

@joccau: GitHub didn't allow me to request PR reviews from the following users: yudongusa.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-02-26T03:46:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, BornChanger, D3Hunter, Frank945946, tiancaiamao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [BornChanger,D3Hunter,bb7133,tiancaiamao]
~~br/OWNERS~~ [BornChanger]
~~pkg/parser/OWNERS~~ [BornChanger,D3Hunter,bb7133,yudongusa]
~~pkg/session/OWNERS~~ [yudongusa]
~~pkg/sessionctx/vardef/OWNERS~~ [yudongusa]
~~pkg/sessionctx/variable/OWNERS~~ [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joccau · 2025-02-26T04:22:59Z

/hold

joccau · 2025-02-26T04:58:51Z

/unhold

close pingcap#59203

ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2025

joccau added 2 commits January 24, 2025 17:54

cherry-pick the the feature about max_user_connections from PingkaiDB…

fdcdc2a

… to community tidb. Signed-off-by: joccau <zak.zhao@pingcap.cn>

modify code

bad08f0

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau force-pushed the cp-max-user-connections branch from c702551 to bad08f0 Compare January 24, 2025 10:04

Merge remote-tracking branch 'origin/master' into cp-max-user-connect…

3e4e094

…ions

joccau changed the title ~~migrate the the feature about max_user_connections from PingkaiDB to community tidb.~~ executor: migrate the the feature about max_user_connections from PingkaiDB to community. Jan 24, 2025

joccau force-pushed the cp-max-user-connections branch from 7bd87b1 to ab3c101 Compare January 24, 2025 14:49

make prepare_bazel

0c43eb2

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau force-pushed the cp-max-user-connections branch from ab3c101 to 0c43eb2 Compare January 24, 2025 14:50

joccau changed the title ~~executor: migrate the the feature about max_user_connections from PingkaiDB to community.~~ executor: migrate the the feature about max_user_connections from PingkaiDB to community | tidb-test=pr/2474 Jan 24, 2025

joccau added 2 commits January 24, 2025 22:59

add license

dbdb08f

Signed-off-by: joccau <zak.zhao@pingcap.cn>

update the scope of variable max_user_connections

b9c3ffc

Signed-off-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot bot added the do-not-merge/needs-linked-issue label Feb 5, 2025

make fmt tidy

380ab52

Signed-off-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Feb 6, 2025

make test

277639e

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau added 2 commits February 7, 2025 18:09

remove useless code

c135df4

Signed-off-by: joccau <zak.zhao@pingcap.cn>

the operation of altering user with max_user_connections need privele…

4b4d35e

…ge of 'create user'. Signed-off-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 25, 2025

tiancaiamao approved these changes Feb 25, 2025

View reviewed changes

Merge remote-tracking branch 'origin' into cp-max-user-connections

141595a

BornChanger approved these changes Feb 25, 2025

View reviewed changes

yudongusa approved these changes Feb 26, 2025

View reviewed changes

ti-chi-bot bot added the approved label Feb 26, 2025

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2025

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2025

ti-chi-bot bot merged commit 87f6c7b into pingcap:master Feb 26, 2025
33 checks passed

zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025

executor: introduce max_user_connections (pingcap#59197)

80dbdb6

close pingcap#59203

budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025

executor: introduce max_user_connections (pingcap#59197)

aa19dec

close pingcap#59203

This was referenced Jun 18, 2025

TiDB panic when start with security.skip-grant-table #61790

Closed

privileges: fix TiDB panic when security.skip-grant-table is true #61791

Merged

Conversation

joccau commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

integration test case

Release note

Uh oh!

codecov bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joccau commented Feb 7, 2025

Uh oh!

tiprow bot commented Feb 7, 2025

Uh oh!

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Uh oh!

joccau commented Feb 25, 2025

Uh oh!

tiprow bot commented Feb 25, 2025

Uh oh!

joccau commented Feb 25, 2025

Uh oh!

ti-chi-bot bot commented Feb 25, 2025

Uh oh!

tiprow bot commented Feb 25, 2025

Uh oh!

joccau commented Feb 25, 2025

Uh oh!

tiprow bot commented Feb 25, 2025

Uh oh!

BornChanger left a comment

Choose a reason for hiding this comment

Uh oh!

joccau commented Feb 25, 2025

Uh oh!

ti-chi-bot bot commented Feb 25, 2025

Uh oh!

joccau commented Feb 25, 2025

Uh oh!

ti-chi-bot bot commented Feb 25, 2025

Uh oh!

joccau commented Feb 25, 2025

Uh oh!

ti-chi-bot bot commented Feb 25, 2025

Uh oh!

ti-chi-bot bot commented Feb 26, 2025

Uh oh!

joccau commented Feb 26, 2025

Uh oh!

joccau commented Feb 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

joccau commented Jan 24, 2025 •

edited

Loading

codecov bot commented Feb 6, 2025 •

edited

Loading