Skip to content

global sort: add boundaries to split keys when generating plan (#58323)#58359

Closed
ti-chi-bot wants to merge 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-58323-to-release-8.5
Closed

global sort: add boundaries to split keys when generating plan (#58323)#58359
ti-chi-bot wants to merge 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-58323-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 17, 2024

This is an automated cherry-pick of #58323

What problem does this PR solve?

Issue Number: close #58267

Problem Summary:

What changed and how does it work?

The data flow of region split keys are long. The requirement of later usage is it must contain the region start/end keys, to correctly pause the PD scheduling of given ranges.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

this test failed in the past

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716 @ti-chi-bot
global sort: add boundaries to split keys when generating plan
21cfd61 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
add comment
7b71e48 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
add UT
0c1751a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
fix bazel
4d791fd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.67568% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@678b713). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.5     #58359   +/-   ##
================================================
  Coverage               ?   56.8607%           
================================================
  Files                  ?       1773           
  Lines                  ?     627067           
  Branches               ?          0           
================================================
  Hits                   ?     356555           
  Misses                 ?     246410           
  Partials               ?      24102
Flag Coverage Δ
integration 36.9312% <75.6756%> (?)
unit 72.5559% <64.8648%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2444% <0.0000%> (?)

@lance6716
Copy link
Contributor

lance6716 commented Dec 18, 2024

replaced by #58356

@lance6716 lance6716 closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lance6716 lance6716

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @lance6716