Skip to content

execdetails: remove useless lmSkipRows#58076

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Lloyd-Pottiger:remove-lm-skip-rows
Dec 25, 2024
Merged

execdetails: remove useless lmSkipRows#58076
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Lloyd-Pottiger:remove-lm-skip-rows

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Dec 9, 2024 •
edited by tangenta
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

dmfileLmFilterScannedRows and dmfileLmFilterSkippedRows are enough.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Lloyd-Pottiger
execdetails: remove useless lmSkipRows
f52fd3a 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2024
@tiprow
Copy link

tiprow bot commented Dec 9, 2024

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta added the skip-issue-check Indicates that a PR no need to check linked issue. label Dec 9, 2024
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Dec 9, 2024
Closed
12 tasks
@codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7776%. Comparing base (a3f823d) to head (bfc67be).
Report is 48 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58076        +/-   ##
================================================
+ Coverage   73.1644%   74.7776%   +1.6132%     
================================================
  Files          1680       1726        +46     
  Lines        463042     480931     +17889     
================================================
+ Hits         338782     359629     +20847     
+ Misses       103453      98987      -4466     
- Partials      20807      22315      +1508
Flag Coverage Δ
integration 49.4637% <ø> (?)
unit 72.4902% <ø> (+0.1896%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 59.5118% <ø> (+13.4950%) ⬆️

zimulala
zimulala reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you briefly describe the meaning of this variable(lmSkipRows) and the variables that can replace it?

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Dec 19, 2024

Could you briefly describe the meaning of this variable(lmSkipRows) and the variables that can replace it?

lmSkipRows means the rows skipped by late materialization, which is the same as dmfileLmFilterSkippedRows now, so remove it.

Lloyd-Pottiger and others added 2 commits December 19, 2024 17:34
@Lloyd-Pottiger
Merge branch 'master' into remove-lm-skip-rows
34f62b4
@Lloyd-Pottiger
address comments
bfc67be 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Dec 24, 2024

/retest

@tiprow
Copy link

tiprow bot commented Dec 24, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xzhangxian1008
xzhangxian1008 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 25, 2024
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Dec 25, 2024

Related tiflash PR: pingcap/tiflash#9709

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zimulala
zimulala approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-25 08:32:01.15302208 +0000 UTC m=+1636911.241824621: ☑️ agreed by xzhangxian1008.
  • 2024-12-25 08:56:35.919824664 +0000 UTC m=+1638386.008627204: ☑️ agreed by zimulala.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, xzhangxian1008, zanmato1984, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [zanmato1984,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link

tiprow bot commented Dec 25, 2024

@Lloyd-Pottiger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow bfc67be link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 1fef963 into pingcap:master Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@zimulala zimulala zimulala approved these changes

+2 more reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Lloyd-Pottiger @JaySon-Huang @zanmato1984 @zimulala @xzhangxian1008 @tangenta