Skip to content

store: refine coprocessor error log#52729

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
crazycs520:refine-log24
Apr 18, 2024
Merged

store: refine coprocessor error log#52729
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
crazycs520:refine-log24

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Apr 18, 2024

What problem does this PR solve?

Issue Number: ref #52464

Problem Summary: refine log for diagnose.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
store: refine coprocessor error log
ae0ef6f 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@tiprow
Copy link

tiprow bot commented Apr 18, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 18, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-18 09:53:31.582448068 +0000 UTC m=+504630.693494520: ☑️ agreed by cfzjywxk.
  • 2024-04-18 09:53:37.487626068 +0000 UTC m=+504636.598672516: ☑️ agreed by MyonKeminta.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 18, 2024 •
edited
Loading

Codecov Report

Merging #52729 (ae0ef6f) into master (72e5460) will increase coverage by 2.0890%.
Report is 1 commits behind head on master.
The diff coverage is 33.3333%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #52729        +/-   ##
================================================
+ Coverage   72.3230%   74.4120%   +2.0890%     
================================================
  Files          1471       1473         +2     
  Lines        427219     427659       +440     
================================================
+ Hits         308978     318230      +9252     
+ Misses        98951      89596      -9355     
- Partials      19290      19833       +543
Flag Coverage Δ
integration 49.1242% <0.0000%> (?)
unit 71.2076% <33.3333%> (+0.0082%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7933% <ø> (+8.6231%) ⬆️

@crazycs520
Copy link
Contributor Author

crazycs520 commented Apr 18, 2024

/retest-required

@tiprow
Copy link

tiprow bot commented Apr 18, 2024

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 14c5a78 into pingcap:master Apr 18, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 25, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #52876.

ti-chi-bot bot pushed a commit that referenced this pull request May 6, 2024
@ti-chi-bot
store: refine coprocessor error log (#52729) (#52876)
755a1c2 
ref #52464
crazycs520 added a commit to crazycs520/tidb that referenced this pull request May 15, 2024
@crazycs520
store: refine coprocessor error log (pingcap#52729)
312d100 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 mentioned this pull request May 21, 2024
Merged
13 tasks
cfzjywxk pushed a commit that referenced this pull request May 21, 2024
@crazycs520 @zyguan
*: add rpc error stats and refine log for diagnose (#53335)
4be26db 
* sessionctx: add sysvar to control exp feats of replica selector

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* *: add rpc error stats and refine log (#52810)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* store: refine coprocessor error log (#52729)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* *: improve log about stale-read query (#52494)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add leader peer id log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787)

close #51660

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: zyguan <zhongyangguan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@zyguan zyguan zyguan approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crazycs520 @ti-chi-bot @cfzjywxk @zyguan @MyonKeminta