restore_data: remove wait apply phase#50316
Conversation
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
|
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
overvenus
left a comment
There was a problem hiding this comment.
Do we need a version check?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50316 +/- ##
=================================================
- Coverage 70.0692% 55.7085% -14.3608%
=================================================
Files 1443 1557 +114
Lines 419903 592941 +173038
=================================================
+ Hits 294223 330319 +36096
- Misses 105398 239820 +134422
- Partials 20282 22802 +2520
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Perhaps, but I will prefer no, or just reuse the global version checking of BR (Reject to restore to older versions but don't try to be compatible with them). Also if I recall right the first released version of disk snapshot backup / recovery should be delivered with logical flashback. (bd081f1 introduces logical flashback, 181fb8e introduces the basic functionality, both to v5.4.0.) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, JmPotato, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@YuJuncen: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
* This is an automated cherry-pick of #50316 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * resolved conflicts Signed-off-by: Yu Juncen <yu745514916@live.com> --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Yu Juncen <yu745514916@live.com> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: Yu Juncen <yu745514916@live.com>
…pingcap#36) close pingcap#50312, close pingcap#50315 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.1 from head ti-chi-bot:cherry-pick-50316-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-50316-to-release-7.1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: failed to apply #50316 on top of branch "release-7.5": |
What problem does this PR solve?
Issue Number: close #50315, close #50312
Problem Summary:
See #50312
What changed and how does it work?
Check List
Tests
(Will run regression test.)
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.