planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...) (#44838) by qw4990 · Pull Request #49733 · pingcap/tidb

qw4990 · 2023-12-22T14:13:58Z

This is an automated cherry-pick of #44838

What problem does this PR solve?

Issue Number: close #44830

Problem Summary: planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...)

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-12-22T14:14:14Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-12-25T06:38:29Z

/test mysql-test

qw4990 · 2023-12-25T06:38:32Z

/test unit-test

tiprow · 2023-12-25T06:38:51Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-12-25T06:38:54Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-12-25T06:47:53Z

[LGTM Timeline notifier]

Timeline:

2023-12-25 06:39:36.197073059 +0000 UTC m=+1461467.234300001: ☑️ agreed by hawkingrei.
2023-12-25 06:47:52.361041208 +0000 UTC m=+1461963.398268134: ☑️ agreed by AilinKid.

qw4990 · 2023-12-25T07:14:16Z

/test mysql-test

tiprow · 2023-12-25T07:14:37Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-12-25T07:17:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, jackysp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,hawkingrei,jackysp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qw4990 · 2023-12-25T07:26:28Z

/test mysql-test

tiprow · 2023-12-25T07:26:50Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-12-25T09:12:15Z

/test mysql-test

tiprow · 2023-12-25T09:12:38Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-12-26T00:17:51Z

/test mysql-test

tiprow · 2023-12-26T00:18:14Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hawkingrei · 2023-12-26T01:38:11Z

/retest

hawkingrei · 2023-12-26T06:25:59Z

/retest

qw4990 · 2023-12-27T00:42:27Z

/test mysql-test

tiprow · 2023-12-27T00:42:50Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-12-27T00:51:59Z

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@81e3f34). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-6.5     #49733   +/-   ##
================================================
  Coverage               ?   73.6499%           
================================================
  Files                  ?       1087           
  Lines                  ?     349718           
  Branches               ?          0           
================================================
  Hits                   ?     257567           
  Misses                 ?      75624           
  Partials               ?      16527

…eys) in ((...), ...) (pingcap#44838) (pingcap#49733) close pingcap#44830

qw4990 added 2 commits December 22, 2023 22:06

fixup

6a6a546

fixup

bf22ee3

qw4990 requested a review from a team as a code owner December 22, 2023 14:13

ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023

fixup

dde61b3

ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 22, 2023

ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved label Dec 22, 2023

hawkingrei approved these changes Dec 25, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 25, 2023

AilinKid approved these changes Dec 25, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2023

jackysp approved these changes Dec 25, 2023

View reviewed changes

ti-chi-bot bot merged commit 81e0e2b into pingcap:release-6.5 Dec 27, 2023

qw4990 added a commit to qw4990/tidb that referenced this pull request Jan 3, 2024

planner: plan cache supports Batch/PointGet converted from (primary k…

507e3a9

…eys) in ((...), ...) (pingcap#44838) (pingcap#49733) close pingcap#44830

qw4990 mentioned this pull request Jan 3, 2024

planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...) #50000

Merged

13 tasks

Conversation

qw4990 commented Dec 22, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

tiprow bot commented Dec 22, 2023

Uh oh!

qw4990 commented Dec 25, 2023

Uh oh!

qw4990 commented Dec 25, 2023

Uh oh!

tiprow bot commented Dec 25, 2023

Uh oh!

tiprow bot commented Dec 25, 2023

Uh oh!

ti-chi-bot bot commented Dec 25, 2023

[LGTM Timeline notifier]

Uh oh!

qw4990 commented Dec 25, 2023

Uh oh!

tiprow bot commented Dec 25, 2023

Uh oh!

ti-chi-bot bot commented Dec 25, 2023

Uh oh!

qw4990 commented Dec 25, 2023

Uh oh!

tiprow bot commented Dec 25, 2023

Uh oh!

qw4990 commented Dec 25, 2023

Uh oh!

tiprow bot commented Dec 25, 2023

Uh oh!

qw4990 commented Dec 26, 2023

Uh oh!

tiprow bot commented Dec 26, 2023

Uh oh!

hawkingrei commented Dec 26, 2023

Uh oh!

hawkingrei commented Dec 26, 2023

Uh oh!

qw4990 commented Dec 27, 2023

Uh oh!

tiprow bot commented Dec 27, 2023

Uh oh!

codecov bot commented Dec 27, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants