Skip to content

pkg/util: refine tidb_server_memory_limit to make the cpu usage more stable (#48927)#49059

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-48927-to-release-6.5
Dec 8, 2023
Merged

pkg/util: refine tidb_server_memory_limit to make the cpu usage more stable (#48927)#49059
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-48927-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 30, 2023

This is an automated cherry-pick of #48927

What problem does this PR solve?

Issue Number: close #48741

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Resolved a bug to improve CPU stability under prolonged high memory usage in tidb-server.

@XuHuaiyu @ti-chi-bot
This is an automated cherry-pick of pingcap#48927
4b92aa8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 30, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2023
@codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@ff2fcec). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #49059   +/-   ##
================================================
  Coverage               ?   73.8005%           
================================================
  Files                  ?       1087           
  Lines                  ?     350504           
  Branches               ?          0           
================================================
  Hits                   ?     258674           
  Misses                 ?      75272           
  Partials               ?      16558

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 07:32:44.470718821 +0000 UTC m=+1426393.135945028: ☑️ agreed by wshwsh12.
  • 2023-12-04 08:09:15.381810037 +0000 UTC m=+1428584.047036231: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 8, 2023
@hawkingrei
Copy link
Member

hawkingrei commented Dec 8, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit b9635d2 into pingcap:release-6.5 Dec 8, 2023
XuHuaiyu pushed a commit to XuHuaiyu/tidb that referenced this pull request Jul 1, 2024
@ti-chi-bot @XuHuaiyu
pkg/util: refine tidb_server_memory_limit to make the cpu usage more …
5575013 
…stable (pingcap#48927) (pingcap#49059)

close pingcap#48741
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48927-to-release-6.5 branch April 15, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees

@XuHuaiyu XuHuaiyu

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @hawkingrei @guo-shaoge @wshwsh12 @XuHuaiyu