Skip to content

planner: don't change the multi stage count's final return type#48675

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
AilinKid:fix-multi-stage-count-return-type
Nov 27, 2023
Merged

planner: don't change the multi stage count's final return type#48675
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
AilinKid:fix-multi-stage-count-return-type

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Nov 17, 2023 •
edited by winoros
Loading

What problem does this PR solve?

Issue Number: close #48643

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: don't change the multi stage count's final return type

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2023
@tiprow
Copy link

tiprow bot commented Nov 17, 2023

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Merging #48675 (4273067) into master (9cf638f) will decrease coverage by 17.4896%.
Report is 24 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #48675         +/-   ##
=================================================
- Coverage   71.0083%   53.5188%   -17.4896%     
=================================================
  Files          1367       1585        +218     
  Lines        404865     596878     +192013     
=================================================
+ Hits         287488     319442      +31954     
- Misses        97372     254910     +157538     
- Partials      20005      22526       +2521
Flag Coverage Δ
integration 35.0936% <0.0000%> (?)
unit 70.9835% <100.0000%> (-0.0248%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 55.4329% <ø> (+2.3560%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue labels Nov 21, 2023
@AilinKid AilinKid removed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Nov 21, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 21, 2023

/retest

@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 21, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 21, 2023
@AilinKid AilinKid force-pushed the fix-multi-stage-count-return-type branch from 8abf6fd to ce1c11b Compare November 21, 2023 09:46
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2023
@AilinKid AilinKid requested a review from MyonKeminta November 23, 2023 07:39
@AilinKid
don't change the multi statge count's final return type
b956d3f 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2023
@AilinKid
.
697d823 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid force-pushed the fix-multi-stage-count-return-type branch from 3a8aa82 to 697d823 Compare November 24, 2023 07:22
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 07:27:14.857992362 +0000 UTC m=+562063.523218556: ☑️ agreed by qw4990.
  • 2023-11-24 12:04:54.67954482 +0000 UTC m=+578723.344771017: ☑️ agreed by winoros.

@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 27, 2023

/retest

@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 27, 2023

/approve

XuHuaiyu
XuHuaiyu reviewed Nov 27, 2023
View reviewed changes
@AilinKid @XuHuaiyu
Update pkg/expression/aggregation/base_func.go
4273067 
Co-authored-by: HuaiyuXu <xuhuaiyu@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990, winoros, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit d38039e into pingcap:master Nov 27, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 27, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 27, 2023

In response to a cherrypick label: new pull request created to branch release-6.1: #48930.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#48675
6d846fa 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 27, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 27, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #48931.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#48675
fd27fde 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 27, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #48932.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 27, 2023
Closed
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2023
@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#48675
d4f6bec 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@AilinKid AilinKid added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 30, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 30, 2023

/run-cherry-picker

@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 30, 2023

/run cherry-picker

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2023

In response to a cherrypick label: new pull request created to branch release-7.5: #49036.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 30, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 4, 2023
@ti-chi-bot
planner: don't change the multi stage count's final return type (#48675…
525084b 
…) (#49036)

close #48643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

the final count aggregation has changed as sum and cause incorrect result.

5 participants

@AilinKid @ti-chi-bot @qw4990 @winoros @XuHuaiyu