Skip to content

extension: fix make enterprise-server failed#47658

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
lcwangchao:make_enterprise-server
Oct 16, 2023
Merged

extension: fix make enterprise-server failed#47658
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
lcwangchao:make_enterprise-server

Conversation

@lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Oct 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #47646

What is changed and how it works?

  1. fix make enterprise-server failed
  2. detect pkg/extension/enterprise/.git to check whether we can get enterprise git hash because .git/modules/extension/enterprise always exits even folderpkg/extension/enterprise not exist

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lcwangchao lcwangchao removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #47658 (2a2da40) into master (34bc3a1) will increase coverage by 0.9105%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47658        +/-   ##
================================================
+ Coverage   71.9564%   72.8669%   +0.9105%     
================================================
  Files          1396       1419        +23     
  Lines        404738     411310      +6572     
================================================
+ Hits         291235     299709      +8474     
+ Misses        93906      92775      -1131     
+ Partials      19597      18826       -771
Flag Coverage Δ
integration 41.2334% <ø> (?)
unit 71.9709% <ø> (+0.0144%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7049% <ø> (-4.2487%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 07:49:44.579541213 +0000 UTC m=+1643382.166651357: ☑️ agreed by CbcWestwolf.
  • 2023-10-16 07:57:02.929112842 +0000 UTC m=+1643820.516222989: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 4b0b47c into pingcap:master Oct 16, 2023
@lcwangchao lcwangchao deleted the make_enterprise-server branch October 16, 2023 08:35
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
@lcwangchao @wuhuizuo
extension: fix make enterprise-server failed (pingcap#47658)
1b220f5 
close pingcap#47646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make enterprise-server does not set TiDBEnterpriseExtensionGitHash

3 participants

@lcwangchao @hawkingrei @CbcWestwolf