Skip to content

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup (#47001)#47341

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-47001-to-release-6.5
Sep 28, 2023
Merged

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup (#47001)#47341
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-47001-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47001

What problem does this PR solve?

Issue Number: ref #46850

Problem Summary:
See the issue.

What is changed and how it works?

A new RPC named "DenyImprotRpcs" has been added to TiKV, which allows us deny importing during backing up.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 27, 2023
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 28, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@e850bf5). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #47341   +/-   ##
================================================
  Coverage               ?   73.6824%           
================================================
  Files                  ?       1085           
  Lines                  ?     348395           
  Branches               ?          0           
================================================
  Hits                   ?     256706           
  Misses                 ?      75228           
  Partials               ?      16461           

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-28 06:31:31.290068424 +0000 UTC m=+83488.877178569: ☑️ agreed by BornChanger.
  • 2023-09-28 08:27:18.120142371 +0000 UTC m=+90435.707252516: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit f961aa5 into pingcap:release-6.5 Sep 28, 2023
BornChanger pushed a commit to BornChanger/tidb that referenced this pull request Sep 28, 2023
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Sep 29, 2023
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
…napshot_backup (pingcap#47001) (pingcap#47341) (pingcap#20)

ref pingcap#46850

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot deleted the cherry-pick-47001-to-release-6.5 branch April 15, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants