Skip to content

*: rename variable tidb_kv_read_timeout to tikv_client_read_timeout and remove tidb_kv_read_timeout hint#46941

Merged
crazycs520 merged 3 commits intopingcap:tidb-6.5-with-kv-timeout-featurefrom
crazycs520:rename-timeout-vars-6.5
Sep 15, 2023
Merged

*: rename variable tidb_kv_read_timeout to tikv_client_read_timeout and remove tidb_kv_read_timeout hint#46941
crazycs520 merged 3 commits intopingcap:tidb-6.5-with-kv-timeout-featurefrom
crazycs520:rename-timeout-vars-6.5

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Sep 13, 2023

What problem does this PR solve?

Issue Number: ref #46713

Problem Summary: cherry-pick 46714

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
*: rename variable tidb_kv_read_timeout to tikv_client_read_timeout a…
816fb4d 
…nd remove tidb_kv_read_timeout hint

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine
4fd5503 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner September 13, 2023 07:36
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from crazycs520. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link

tiprow bot commented Sep 13, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
fix test
9704962 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 merged commit e9ff709 into pingcap:tidb-6.5-with-kv-timeout-feature Sep 15, 2023
@crazycs520 crazycs520 deleted the rename-timeout-vars-6.5 branch September 15, 2023 06:18
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @crazycs520
*: rename variable tidb_kv_read_timeout to tikv_client_read_timeout a…
4cd95b2 
…nd remove tidb_kv_read_timeout hint (pingcap#46941) (pingcap#5)

Co-authored-by: crazycs <crazycs520@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@crazycs520