Skip to content

metrics: refine metrics of infoschema#46612

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
crazycs520:refine-infoschema-metric
Sep 4, 2023
Merged

metrics: refine metrics of infoschema#46612
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
crazycs520:refine-infoschema-metric

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Sep 4, 2023

What problem does this PR solve?

Issue Number: ref #46524

Problem Summary: refine metrics of infoschema

What is changed and how it works?

  • Remove duplicate metrics panel Load Schema Duration
  • Load Schema OPS add information about load snapshot schema, it's important to diagnose problem for stale read request.
  • Add Schema Cache OPS metric panel.

Before this PR:

image

This PR:

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
domain: enlarge infoCache capacity to avoid cache miss and add metric…
26c809f 
… in grafana

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine metrics
0e85df7 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine metrics
a98b116 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
make bazel_prepare
01e55af 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
fix
e2a6f47 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2023
@crazycs520
Copy link
Contributor Author

crazycs520 commented Sep 4, 2023

@xhebox @zimulala PTAL

@tiprow
Copy link

tiprow bot commented Sep 4, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

crazycs520 commented Sep 4, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 4, 2023
zimulala
zimulala approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-04 03:09:46.046677502 +0000 UTC m=+2328550.595693474: ☑️ agreed by zimulala.
  • 2023-09-04 03:10:59.154369248 +0000 UTC m=+2328623.703385221: ☑️ agreed by xhebox.

@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #46612 (e2a6f47) into master (7e66761) will decrease coverage by 0.5870%.
Report is 27 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46612        +/-   ##
================================================
- Coverage   73.3392%   72.7522%   -0.5870%     
================================================
  Files          1309       1331        +22     
  Lines        394535     401505      +6970     
================================================
+ Hits         289349     292104      +2755     
- Misses        86772      90919      +4147     
- Partials      18414      18482        +68
Flag Coverage Δ
integration 25.4922% <92.3076%> (?)
unit 73.4398% <100.0000%> (+0.1006%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9628% <ø> (-0.0145%) ⬇️
br 48.0358% <ø> (-4.3149%) ⬇️

@hawkingrei
Copy link
Member

hawkingrei commented Sep 4, 2023

/retest

@hawkingrei
Copy link
Member

hawkingrei commented Sep 4, 2023

/test all

@hawkingrei
Copy link
Member

hawkingrei commented Sep 4, 2023

/retest

1 similar comment
@hawkingrei
Copy link
Member

hawkingrei commented Sep 4, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit ee76cd8 into pingcap:master Sep 4, 2023
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Sep 5, 2023
@crazycs520
metrics: refine metrics of infoschema (pingcap#46612)
f0f4dea 
ref pingcap#46524
@crazycs520 crazycs520 mentioned this pull request Sep 5, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

approved component/metrics lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crazycs520 @hawkingrei @zimulala @xhebox