Skip to content

schema cache: record the ddl timestamp and associate schema cache with the timestamp for stale read (#42083)#46588

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
crazycs520:info-cache-pick
Sep 1, 2023
Merged

schema cache: record the ddl timestamp and associate schema cache with the timestamp for stale read (#42083)#46588
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
crazycs520:info-cache-pick

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Sep 1, 2023 •
edited by zyguan
Loading

What problem does this PR solve?

Issue Number: ref #43481

Problem Summary: cherry-pick:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2023
@tiprow
Copy link

tiprow bot commented Sep 1, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@d7ce2f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46588   +/-   ##
================================================
  Coverage               ?   73.6858%           
================================================
  Files                  ?       1084           
  Lines                  ?     348159           
  Branches               ?          0           
================================================
  Hits                   ?     256544           
  Misses                 ?      75156           
  Partials               ?      16459

@crazycs520 crazycs520 requested a review from xhebox September 1, 2023 06:10
@crazycs520
Copy link
Contributor Author

crazycs520 commented Sep 1, 2023

@xhebox PTAL

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-01 06:12:24.789405005 +0000 UTC m=+2080309.338420977: ☑️ agreed by xhebox.
  • 2023-09-01 07:48:34.591864965 +0000 UTC m=+2086079.140880947: ☑️ agreed by you06.

@cfzjywxk cfzjywxk closed this Sep 1, 2023
@cfzjywxk cfzjywxk reopened this Sep 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 1, 2023
@crazycs520
Copy link
Contributor Author

crazycs520 commented Sep 1, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 1, 2023

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit df1106e into pingcap:release-6.5 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@you06 you06 you06 approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@crazycs520 @xhebox @you06 @hawkingrei @cfzjywxk @ti-chi-bot @hihihuhu