Skip to content

schema cache: fix wrong timestamp in schema cache#46326

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
hihihuhu:schema_cache
Aug 29, 2023
Merged

schema cache: fix wrong timestamp in schema cache#46326
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
hihihuhu:schema_cache

Conversation

@hihihuhu
Copy link
Contributor

@hihihuhu hihihuhu commented Aug 22, 2023

What problem does this PR solve?

correct the wrong timestamp in schema cache to make it useful

Issue Number: close #46325

Problem Summary:

What is changed and how it works?

try to update the timestamp of the existing schema cache when the timestamp is fetched

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2023

Hi @hihihuhu. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 22, 2023

Hi @hihihuhu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xhebox
xhebox reviewed Aug 23, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 25, 2023
@xhebox
Copy link
Contributor

xhebox commented Aug 25, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #46326 (db6db07) into master (1ea6499) will decrease coverage by 0.5435%.
Report is 54 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46326        +/-   ##
================================================
- Coverage   73.3647%   72.8212%   -0.5435%     
================================================
  Files          1288       1320        +32     
  Lines        393441     400604      +7163     
================================================
+ Hits         288647     291725      +3078     
- Misses        86427      90451      +4024     
- Partials      18367      18428        +61
Flag Coverage Δ
integration 25.6752% <0.0000%> (?)
unit 73.4994% <100.0000%> (+0.1346%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0741% <ø> (+0.0036%) ⬆️
br 48.0514% <ø> (-4.1897%) ⬇️

@hihihuhu
Copy link
Contributor Author

hihihuhu commented Aug 28, 2023

/retest

@hihihuhu
Copy link
Contributor Author

hihihuhu commented Aug 28, 2023

/retest

@hawkingrei
Copy link
Member

hawkingrei commented Aug 29, 2023

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 02:33:28.903552743 +0000 UTC m=+1462373.452568729: ☑️ agreed by xhebox.
  • 2023-08-29 02:04:53.865420682 +0000 UTC m=+1806258.414436669: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 9176d20 into pingcap:master Aug 29, 2023
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Sep 1, 2023
@hihihuhu @crazycs520
schema cache: fix wrong timestamp in schema cache (pingcap#46326)
d86325d 
close pingcap#46325
@crazycs520 crazycs520 mentioned this pull request Sep 1, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

schema cache should try to correct previous wrong timestamp

3 participants

@hihihuhu @xhebox @hawkingrei