client-go: attach request source with retry info for coprocessor by you06 · Pull Request #46509 · pingcap/tidb

you06 · 2023-08-30T08:42:11Z

What problem does this PR solve?

Issue Number: close #46514

Problem Summary:

What is changed and how it works?

Update client-go which will attach the request source with retry info for KV requests. This PR set the required options for coprocessor to enable the extra retry info.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: you06 <you1474600@gmail.com>

tiprow · 2023-08-30T08:42:38Z

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

you06 · 2023-08-31T02:11:09Z

/ok-to-test

hawkingrei · 2023-08-31T02:45:56Z

/test all

codecov · 2023-08-31T02:56:16Z

Codecov Report

Merging #46509 (e9a5189) into master (d1483b8) will decrease coverage by 0.8794%.
Report is 40 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #46509        +/-   ##
================================================
- Coverage   73.3755%   72.4961%   -0.8794%     
================================================
  Files          1303       1332        +29     
  Lines        394509     404591     +10082     
================================================
+ Hits         289473     293313      +3840     
- Misses        86640      92776      +6136     
- Partials      18396      18502       +106

Flag	Coverage Δ
integration	`25.7408% <100.0000%> (?)`
unit	`73.4582% <100.0000%> (+0.0827%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`84.9628% <ø> (-0.1011%)`	⬇️
br	`47.1104% <ø> (-5.2485%)`	⬇️

hawkingrei · 2023-08-31T03:00:44Z

/retest

you06 · 2023-09-01T06:01:18Z

session/session.go

-		} else {
-			s.sessionVars.RequestSourceType = stmtLabel
 		}
+		s.sessionVars.RequestSourceType = stmtLabel


This is a tiny fix because coprocessor will read request source from the session variables.

you06 · 2023-09-01T06:01:26Z

/retest

Signed-off-by: you06 <you1474600@gmail.com>

you06 · 2023-09-01T07:07:07Z

/retest

ti-chi-bot · 2023-09-01T08:42:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ekexium,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-09-01T08:42:09Z

[LGTM Timeline notifier]

Timeline:

2023-09-01 06:54:34.201704682 +0000 UTC m=+2082838.750720668: ☑️ agreed by ekexium.
2023-09-01 08:42:08.687357083 +0000 UTC m=+2089293.236373070: ☑️ agreed by zyguan.

you06 · 2023-09-01T09:21:19Z

/retest

cfzjywxk · 2023-09-01T13:57:27Z

/merge

ti-chi-bot · 2023-09-01T13:57:29Z

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

hawkingrei · 2023-09-02T03:24:28Z

/retest

hawkingrei · 2023-09-02T10:51:04Z

/test all

tiprow · 2023-09-02T11:13:11Z

@you06: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	`e9a5189`	link	true	`/test tiprow_fast_test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot · 2023-09-06T03:03:21Z

In response to a cherrypick label: new pull request created to branch release-7.1: #46705.

ti-chi-bot · 2023-09-06T03:03:23Z

In response to a cherrypick label: new pull request created to branch release-6.5: #46706.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

) (#46706) close #46514

…gcap#46509) (pingcap#46706) close pingcap#46514

) (#47003) * client-go: attach request source with retry info for coprocessor (#46509) (#46706) close #46514 * restore bazelversiong Signed-off-by: you06 <you1474600@gmail.com> * remove unused field Signed-off-by: you06 <you1474600@gmail.com> * update client-go Signed-off-by: you06 <you1474600@gmail.com> --------- Signed-off-by: you06 <you1474600@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> resolve conflict Signed-off-by: you06 <you1474600@gmail.com>

) (#46705) close #46514

…gcap#46706) (pingcap#47003) (pingcap#6) * client-go: attach request source with retry info for coprocessor (pingcap#46509) (pingcap#46706) close pingcap#46514 * restore bazelversiong Signed-off-by: you06 <you1474600@gmail.com> * remove unused field Signed-off-by: you06 <you1474600@gmail.com> * update client-go Signed-off-by: you06 <you1474600@gmail.com> --------- Signed-off-by: you06 <you1474600@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: you06 <you1474600@gmail.com> Co-authored-by: you06 <you1474600@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

record retry info for coprocessor

11415ce

Signed-off-by: you06 <you1474600@gmail.com>

ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2023

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Aug 30, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 31, 2023

you06 commented Sep 1, 2023

View reviewed changes

fix test

e9a5189

Signed-off-by: you06 <you1474600@gmail.com>

you06 changed the title ~~attach request source with retry info for coprocessor~~ client-go: attach request source with retry info for coprocessor Sep 1, 2023

ti-chi-bot bot removed the do-not-merge/invalid-title label Sep 1, 2023

ekexium approved these changes Sep 1, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 1, 2023

zyguan approved these changes Sep 1, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 1, 2023

ti-chi-bot bot merged commit b524a23 into pingcap:master Sep 2, 2023

you06 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 6, 2023

ti-chi-bot mentioned this pull request Sep 6, 2023

client-go: attach request source with retry info for coprocessor (#46509) #46705

Merged

12 tasks

ti-chi-bot mentioned this pull request Sep 6, 2023

client-go: attach request source with retry info for coprocessor (#46509) #46706

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2023

This is an automated cherry-pick of pingcap#46509

80a494c

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot bot pushed a commit that referenced this pull request Sep 7, 2023

client-go: attach request source with retry info for coprocessor (#46509

cbfa816

) (#46706) close #46514

you06 pushed a commit to you06/tidb that referenced this pull request Sep 18, 2023

client-go: attach request source with retry info for coprocessor (pin…

778b007

…gcap#46509) (pingcap#46706) close pingcap#46514

you06 added a commit to ti-chi-bot/tidb that referenced this pull request Oct 16, 2023

This is an automated cherry-pick of pingcap#46509

c26099c

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> resolve conflict Signed-off-by: you06 <you1474600@gmail.com>

ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023

client-go: attach request source with retry info for coprocessor (#46509

359aea8

) (#46705) close #46514

Conversation

you06 commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

tiprow bot commented Aug 30, 2023

Uh oh!

you06 commented Aug 31, 2023

Uh oh!

hawkingrei commented Aug 31, 2023

Uh oh!

codecov bot commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hawkingrei commented Aug 31, 2023

Uh oh!

you06 Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

you06 commented Sep 1, 2023

Uh oh!

you06 commented Sep 1, 2023

Uh oh!

ti-chi-bot bot commented Sep 1, 2023

Uh oh!

ti-chi-bot bot commented Sep 1, 2023

[LGTM Timeline notifier]

Uh oh!

you06 commented Sep 1, 2023

Uh oh!

cfzjywxk commented Sep 1, 2023

Uh oh!

ti-chi-bot bot commented Sep 1, 2023

Uh oh!

hawkingrei commented Sep 2, 2023

Uh oh!

hawkingrei commented Sep 2, 2023

Uh oh!

tiprow bot commented Sep 2, 2023

Uh oh!

ti-chi-bot commented Sep 6, 2023

Uh oh!

ti-chi-bot commented Sep 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

you06 commented Aug 30, 2023 •

edited

Loading

codecov bot commented Aug 31, 2023 •

edited

Loading