Skip to content

kv request: configurable KV Timeout (#45601)#46274

Merged
cfzjywxk merged 6 commits intopingcap:tidb-6.5-with-kv-timeout-featurefrom
crazycs520:tidb-6.5-timeout
Aug 23, 2023
Merged

kv request: configurable KV Timeout (#45601)#46274
cfzjywxk merged 6 commits intopingcap:tidb-6.5-with-kv-timeout-featurefrom
crazycs520:tidb-6.5-timeout

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Aug 21, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: cherry-pick #45601
release PR: tikv/client-go#948

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hihihuhu and others added 2 commits August 21, 2023 14:47
@hihihuhu @crazycs520
kv request: configurable KV Timeout (pingcap#45601)
e9c1e53 
close pingcap#45380
@crazycs520
update go.mod
fa9d81c 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner August 21, 2023 07:02
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 21, 2023
@tiprow
Copy link

tiprow bot commented Aug 21, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
refine code
5901983 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
make bazel_prepare
1dfa0d0 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@zhangjinpeng87 zhangjinpeng87 changed the title kv request: configurable KV Timeout (#45601) [DNM]kv request: configurable KV Timeout (#45601) Aug 21, 2023
@crazycs520
update go.mod
dc19b6f 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2023

@crazycs520: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test dc19b6f link true /test unit-test
idc-jenkins-ci-tidb/build dc19b6f link true /test build
idc-jenkins-ci-tidb/check_dev dc19b6f link true /test check-dev

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crazycs520 crazycs520 changed the base branch from release-6.5 to tidb-6.5-with-kv-timeout-feature August 22, 2023 08:34
cfzjywxk
cfzjywxk reviewed Aug 23, 2023
View reviewed changes
@crazycs520 crazycs520 changed the title [DNM]kv request: configurable KV Timeout (#45601) kv request: configurable KV Timeout (#45601) Aug 23, 2023
@crazycs520
update go.mod
6a269b1 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from crazycs520. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crazycs520
Copy link
Contributor Author

crazycs520 commented Aug 23, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 23, 2023

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

crazycs520 commented Aug 23, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 23, 2023
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Aug 23, 2023

/retest

@cfzjywxk cfzjywxk merged commit 1f2d0cc into pingcap:tidb-6.5-with-kv-timeout-feature Aug 23, 2023
cfzjywxk pushed a commit that referenced this pull request Aug 29, 2023
@crazycs520 @hihihuhu @cfzjywxk
kv request: configurable KV Timeout (#45601) (#46274)
5dc9f2d 
* kv request: configurable KV Timeout (#45601)

close #45380

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine code

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* make bazel_prepare

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: Chen Ding <dingc05@gmail.com>
cfzjywxk pushed a commit that referenced this pull request Sep 1, 2023
@crazycs520 @hihihuhu @cfzjywxk
kv request: configurable KV Timeout (#45601) (#46274)
7055113 
* kv request: configurable KV Timeout (#45601)

close #45380

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* refine code

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* make bazel_prepare

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: Chen Ding <dingc05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk left review comments

@zyguan zyguan Awaiting requested review from zyguan

@you06 you06 Awaiting requested review from you06

@ekexium ekexium Awaiting requested review from ekexium

Assignees

No one assigned

Labels

ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crazycs520 @cfzjywxk @hihihuhu