Skip to content

tests: make test TestRuntimeHintsInEvolveTasks stable#46152

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
crazycs520:fix-test000
Aug 16, 2023
Merged

tests: make test TestRuntimeHintsInEvolveTasks stable#46152
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
crazycs520:fix-test000

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Aug 16, 2023

What problem does this PR solve?

Issue Number: close #46124

Problem Summary: make test TestRuntimeHintsInEvolveTasks stable.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
tests: make test TestRuntimeHintsInEvolveTasks stable
496caa5 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@tiprow
Copy link

tiprow bot commented Aug 16, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

crazycs520 commented Aug 16, 2023

@hawkingrei @winoros PTAL

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2023
@hawkingrei
Copy link
Member

hawkingrei commented Aug 16, 2023

/check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 08:06:41.180328875 +0000 UTC m=+704765.729344848: ☑️ agreed by hawkingrei.
  • 2023-08-16 08:08:38.295171841 +0000 UTC m=+704882.844187826: ☑️ agreed by qw4990.

@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #46152 (496caa5) into master (0e1b642) will decrease coverage by 1.9827%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46152        +/-   ##
================================================
- Coverage   74.7874%   72.8047%   -1.9827%     
================================================
  Files          1296       1304         +8     
  Lines        398623     401041      +2418     
================================================
- Hits         298120     291977      -6143     
- Misses        81133      90592      +9459     
+ Partials      19370      18472       -898
Flag Coverage Δ
integration 25.6669% <100.0000%> (-20.5987%) ⬇️
unit 73.4808% <ø> (+0.1057%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0656% <ø> (-0.0109%) ⬇️
br 47.8082% <ø> (-16.7393%) ⬇️

@hawkingrei
Copy link
Member

hawkingrei commented Aug 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit cf8a74b into pingcap:master Aug 16, 2023
crazycs520 added a commit that referenced this pull request Aug 29, 2023
@crazycs520
tests: make test TestRuntimeHintsInEvolveTasks stable (#46152)
662be89 
close #46124
cfzjywxk pushed a commit that referenced this pull request Sep 1, 2023
@crazycs520 @cfzjywxk
tests: make test TestRuntimeHintsInEvolveTasks stable (#46152)
97750a2 
close #46124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky test TestRuntimeHintsInEvolveTasks

3 participants

@crazycs520 @hawkingrei @qw4990