Skip to content

lightning: retry for leader change error when GetTS (#44478) (#44856) #45330

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.1from
lance6716:fix45301
Jul 13, 2023
Merged

lightning: retry for leader change error when GetTS (#44478) (#44856) #45330
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.1from
lance6716:fix45301

Conversation

@lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jul 12, 2023

manually cherry-pick (#44478) (#44856)

What problem does this PR solve?

Issue Number: close #45301

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Jul 12, 2023

/cc @D3Hunter @GMHDBJD

@ti-chi-bot ti-chi-bot bot requested review from D3Hunter and GMHDBJD July 12, 2023 09:50
@tiprow
Copy link

tiprow bot commented Jul 12, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD
GMHDBJD approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-12 09:57:13.201356192 +0000 UTC m=+498724.971694906: ☑️ agreed by GMHDBJD.
  • 2023-07-12 09:57:40.100010473 +0000 UTC m=+498751.870349185: ☑️ agreed by lichunzhu.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 04f6570 into pingcap:release-7.1 Jul 13, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Jul 14, 2023

/cherry-pick release-6.5
/cherry-pick release-6.1

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2023

@lance6716: new pull request created to branch release-6.1: #45358.

Details

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 14, 2023
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#45330
19fc850 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2023

@lance6716: new pull request created to branch release-6.5: #45359.

Details

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 14, 2023
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#45330
ed9193b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@lance6716 lance6716 mentioned this pull request Sep 4, 2023
Merged
12 tasks
@Benjamin2037 Benjamin2037 mentioned this pull request Oct 18, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

+1 more reviewer

@lichunzhu lichunzhu lichunzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lance6716 @ti-chi-bot @lichunzhu @GMHDBJD