Skip to content

ddl: fix ingest checkpoint not resumed for empty partitions#44271

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
tangenta:add-index-empty-partition
May 30, 2023
Merged

ddl: fix ingest checkpoint not resumed for empty partitions#44271
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
tangenta:add-index-empty-partition

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented May 30, 2023 •
edited by wjhuang2016
Loading

What problem does this PR solve?

Issue Number: close #44265

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels May 30, 2023
@tangenta
Copy link
Contributor Author

tangenta commented May 30, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2023
@tangenta tangenta mentioned this pull request May 30, 2023
Merged
12 tasks
zimulala
zimulala approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@zimulala
Copy link
Contributor

zimulala commented May 30, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 31e7595

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@hawkingrei
Copy link
Member

hawkingrei commented May 30, 2023

/retest

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@tangenta
ddl: fix ingest checkpoint not resumed for empty partitions (#44271) (#…
635a436 
…44282)

close #44265
@tangenta
Copy link
Contributor Author

tangenta commented May 30, 2023

retest

@tangenta
Copy link
Contributor Author

tangenta commented May 30, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1e1747e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@hawkingrei
Copy link
Member

hawkingrei commented May 30, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 65d5ef2 into pingcap:master May 30, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2023

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.1 from head ti-chi-bot:cherry-pick-44271-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.1 and ti-chi-bot:cherry-pick-44271-to-release-7.1"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

data index inconsistent after DDL owner change (such as upgrade the cluster)

5 participants

@tangenta @zimulala @hawkingrei @ti-chi-bot @wjhuang2016