planner, json: restore cast flag after substitute column in cast (#39997)#44100
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from May 29, 2023
Merged
Conversation
4 tasks
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Member
|
/retest |
hawkingrei
approved these changes
May 24, 2023
xhebox
approved these changes
May 29, 2023
Contributor
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: c7dc4f4da3859f6f32d4ac7a7353b35dca949ea8 |
Member
|
/retest |
1 similar comment
Member
|
/retest |
Member
|
Wait for #44233 |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
c7dc4f4 to
65968f9
Compare
Member
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 65968f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #39997
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #39806
Problem Summary:
json functions use a flag
mysql.ParseToJSONFlagto mark whether thecastStringAsJsonfunction should try to parse the string as a json, or simply convert the string to a json string. For example, with this flag,abcdis not a valid json, and will return an error. Without this flag,abcdwill be casted to"abcd".What is changed and how it works?
Check List
Tests
Release note