ddl: return early when encounter error in BackendCtx.Unregister()#43326
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Apr 23, 2023
Merged
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
wjhuang2016
approved these changes
Apr 23, 2023
Contributor
Author
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 55dd1ef |
12 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
wjhuang2016
added a commit
to wjhuang2016/tidb
that referenced
this pull request
Jan 5, 2026
Add test cases for the following previously uncovered scenarios: 1. TestIngestOwnerTransferEmptyPartition (pingcap#44265): Tests owner transfer with empty partitions ensures checkpoint contains partition ID. 2. TestIngestPartitionCheckpointRecovery (pingcap#43997/pingcap#44024): Tests that checkpoint correctly saves partition info for recovery. 3. TestIngestConcurrentJobCleanupRace (pingcap#44137/pingcap#44140): Tests parallel add index jobs don't cause panic from cleanup race. 4. TestIngestCancelCleanupOrder (pingcap#43323/pingcap#43326): Tests cancel during execution doesn't cause nil pointer panic. 5. TestIngestGCSafepointBlocking (pingcap#40074/pingcap#40081): Tests add index uses correct TS and blocks GC safepoint advancement. 6. TestCheckpointInstanceAddrValidation (pingcap#43983/pingcap#43957): Tests checkpoint instance address validation works correctly. 7. TestCheckpointPhysicalIDValidation: Tests checkpoint physical table ID validation during recovery. Co-Authored-By: Warp <agent@warp.dev>
wjhuang2016
added a commit
to wjhuang2016/tidb
that referenced
this pull request
Jan 5, 2026
Add test cases for the following previously uncovered scenarios: 1. TestIngestOwnerTransferEmptyPartition (pingcap#44265): Tests owner transfer with empty partitions ensures checkpoint contains partition ID. 2. TestIngestPartitionCheckpointRecovery (pingcap#43997/pingcap#44024): Tests that checkpoint correctly saves partition info for recovery. 3. TestIngestConcurrentJobCleanupRace (pingcap#44137/pingcap#44140): Tests parallel add index jobs don't cause panic from cleanup race. 4. TestIngestCancelCleanupOrder (pingcap#43323/pingcap#43326): Tests cancel during execution doesn't cause nil pointer panic. 5. TestIngestGCSafepointBlocking (pingcap#40074/pingcap#40081): Tests add index uses correct TS and blocks GC safepoint advancement. 6. TestCheckpointInstanceAddrValidation (pingcap#43983/pingcap#43957): Tests checkpoint instance address validation works correctly. 7. TestCheckpointPhysicalIDValidation: Tests checkpoint physical table ID validation during recovery.
wjhuang2016
added a commit
to wjhuang2016/tidb
that referenced
this pull request
Jan 5, 2026
Add test cases for the following previously uncovered scenarios: 1. TestIngestOwnerTransferEmptyPartition (pingcap#44265): Tests owner transfer with empty partitions ensures checkpoint contains partition ID. 2. TestIngestPartitionCheckpointRecovery (pingcap#43997/pingcap#44024): Tests that checkpoint correctly saves partition info for recovery. 3. TestIngestConcurrentJobCleanupRace (pingcap#44137/pingcap#44140): Tests parallel add index jobs don't cause panic from cleanup race. 4. TestIngestCancelCleanupOrder (pingcap#43323/pingcap#43326): Tests cancel during execution doesn't cause nil pointer panic. 5. TestIngestGCSafepointBlocking (pingcap#40074/pingcap#40081): Tests add index uses correct TS and blocks GC safepoint advancement. 6. TestCheckpointInstanceAddrValidation (pingcap#43983/pingcap#43957): Tests checkpoint instance address validation works correctly. 7. TestCheckpointPhysicalIDValidation: Tests checkpoint physical table ID validation during recovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #43323
Problem Summary:
DROP INDEXas a rollback job.convertAddIdxJob2RollbackJob,cleanupLocalIndexData()is invoked to remove the lightning sort path.BackendCtx.Unregister(), TiDB fails to close the engine because the sort path is removed.delete-only, however the job is statecancelled.What is changed and how it works?
To address step 2 and step 4, this PR
cleanupLocalIndexData()because the sort path removing is considered byUnregister().BackendCtx.Unregister()Check List
Tests
ADD INDEXjob successfully.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.