Skip to content

*: optimize mpp probe#39932

Merged
ti-chi-bot merged 33 commits intopingcap:masterfrom
hackersean:sean/optimize-mpp-probe
Dec 22, 2022
Merged

*: optimize mpp probe#39932
ti-chi-bot merged 33 commits intopingcap:masterfrom
hackersean:sean/optimize-mpp-probe

Conversation

@hackersean
Copy link
Contributor

@hackersean hackersean commented Dec 14, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39686

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fixdb
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2022
@hackersean hackersean changed the title Sean/optimize mpp probe ‘’ optimize mpp probe [WIP] Dec 14, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Dec 14, 2022
@hackersean hackersean force-pushed the sean/optimize-mpp-probe branch 2 times, most recently from 6ba459e to bfd4d86 Compare December 15, 2022 09:33
@hackersean hackersean force-pushed the sean/optimize-mpp-probe branch 2 times, most recently from e37826a to 0b9c7c7 Compare December 16, 2022 02:46
@hackersean hackersean force-pushed the sean/optimize-mpp-probe branch from 0b9c7c7 to b86ec48 Compare December 16, 2022 02:47
@hackersean hackersean requested a review from a team as a code owner December 16, 2022 03:08
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2022
@hackersean hackersean force-pushed the sean/optimize-mpp-probe branch 2 times, most recently from ed1b352 to 1cd580f Compare December 16, 2022 03:21
@hackersean hackersean force-pushed the sean/optimize-mpp-probe branch 2 times, most recently from b33b4df to 703768e Compare December 16, 2022 11:10
@ti-chi-bot ti-chi-bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 16, 2022
@hackersean
Copy link
Contributor Author

hackersean commented Dec 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

@hackersean: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hackersean
Copy link
Contributor Author

hackersean commented Dec 22, 2022

/assign @pingcap/tidb-committers

@windtalker
Copy link
Contributor

windtalker commented Dec 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 54dc11e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2022
@ti-chi-bot ti-chi-bot merged commit aeccf77 into pingcap:master Dec 22, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

In response to a cherrypick label: new pull request created to branch release-5.3: #40104.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 22, 2022
@hackersean @ti-chi-bot
This is an automated cherry-pick of pingcap#39932
0201877 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

In response to a cherrypick label: new pull request created to branch release-5.4: #40106.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 22, 2022
@hackersean @ti-chi-bot
This is an automated cherry-pick of pingcap#39932
aaf15a7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

In response to a cherrypick label: new pull request created to branch release-6.1: #40107.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 22, 2022
@hackersean @ti-chi-bot
This is an automated cherry-pick of pingcap#39932
8d8a022 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

In response to a cherrypick label: new pull request created to branch release-6.5: #40108.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 22, 2022
@hackersean @ti-chi-bot
This is an automated cherry-pick of pingcap#39932
97354fb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@sre-bot
Copy link
Contributor

sre-bot commented Dec 22, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 3 min 46 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 28 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 40 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 54 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

/cherry-pick-invite

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

@ti-chi-bot you're already a collaborator in repo ti-chi-bot/tidb

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Dec 22, 2022

/cherry-pick-invite

3 similar comments
@hackersean
Copy link
Contributor Author

hackersean commented Dec 22, 2022

/cherry-pick-invite

@hackersean
Copy link
Contributor Author

hackersean commented Dec 22, 2022

/cherry-pick-invite

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Dec 22, 2022

/cherry-pick-invite

ti-chi-bot added a commit that referenced this pull request Dec 22, 2022
@ti-chi-bot
*: optimize mpp probe (#39932) (#40108)
4d466ba 
close #39686
morgo added a commit to morgo/tidb that referenced this pull request Dec 23, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into add-bootstrap-sql
db4fe52 
* upstream/master: (1323 commits)
  ttl: escape parameters for finish job sql (pingcap#40118)
  statistics: fix incorrect datetime value when loading stats (pingcap#40084)
  planner: move code of generating IndexMergePath to a separated file (pingcap#40134)
  ddl: set context correctly in the setDDLLabelForDiagnosis (pingcap#40090)
  parser: fix cast function restore (pingcap#40129)
  ddl: fix issue of partition table with foreign key and add more test case (pingcap#40122)
  ddl: fix issue of add foreign key too slow in big table (pingcap#40112)
  *: support foreign key check/cascade when execute replace into statement (pingcap#40069)
  server: support download plan replayer continues capture file (pingcap#40085)
  statistics: fix the sync load sql did'nt running internally (pingcap#40087)
  *: optimize mpp probe (pingcap#39932)
  server: avoid reusing cached stmt ctx on cursor read (pingcap#40023)
  metrics: add metrics for ema cpu metrics and GOGC (pingcap#40049)
  *: filter particularly errors when `truncateAsWarning` is true (pingcap#40078)
  parser: support keep_order and no_keep_order hint (pingcap#39965)
  planner: check the `ignore-plan-cache` hint in insert-stmt (pingcap#40080)
  *: fix issue of multi-schema change with foreign key (pingcap#40042)
  sysvar: allow modifying 'tidb_allow_remove_auto_inc' when SEM is ON (pingcap#40083)
  ddl: check the limitation when creating multi-valued index  (pingcap#39818)
  planner: support set binding status by sql digest (pingcap#39517)
  ...
@guo-shaoge guo-shaoge mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fixdb fixdb fixdb approved these changes

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The response time is not reasonable when 1 tiflash is hanging

8 participants

@hackersean @ti-chi-bot @sre-bot @windtalker @wuhuizuo @fixdb @XuHuaiyu @hawkingrei