Skip to content

txn: workaround memdb panic#39741

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
ekexium:fix-memdb-when-panic
Dec 8, 2022
Merged

txn: workaround memdb panic#39741
ti-chi-bot merged 4 commits intopingcap:masterfrom
ekexium:fix-memdb-when-panic

Conversation

@ekexium
Copy link
Member

@ekexium ekexium commented Dec 7, 2022 •
edited
Loading

Signed-off-by: ekexium eke@fastmail.com

What problem does this PR solve?

Issue Number: close #39611

Problem Summary:

This is only a workaround. I think we should detach memdb tracker from the session tracker before we figure out the safe actions when exceeding quota

I discussed with @XuHuaiyu and decided to only work it around for now since previous mem-quota mechanism doesn't find anomalies from TiDB's transaction part.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ekexium
replace client-go to workaround memdb panic
d44ab03 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2022
@ekexium ekexium changed the title txn:workaround memdb panic txn: workaround memdb panic Dec 7, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2022
@ekexium
update client-go
4c1bce0 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2022
@ekexium
Copy link
Member Author

ekexium commented Dec 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 211e0c9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2022
@ti-chi-bot ti-chi-bot merged commit a8fff0f into pingcap:master Dec 8, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 8, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022

In response to a cherrypick label: new pull request created: #39757.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 8, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 2, success 38, total 40 28 min New failing
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 1, success 27, total 28 6 min 32 sec New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 4 min 40 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot added a commit that referenced this pull request Dec 8, 2022
@ti-chi-bot
txn: workaround memdb panic (#39741) (#39757)
1bef7eb 
close #39611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@disksing disksing disksing approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tidb panic when processing insert select query

6 participants

@ekexium @ti-chi-bot @sre-bot @xhebox @disksing @hawkingrei