Skip to content

ddl: handle ErrNotOwner properly for modify column#39645

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
zimulala:zimuxia/ctc-not-owner
Dec 7, 2022
Merged

ddl: handle ErrNotOwner properly for modify column#39645
ti-chi-bot merged 5 commits intopingcap:masterfrom
zimulala:zimuxia/ctc-not-owner

Conversation

@zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 5, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39643, close #39644

Problem Summary:
The fail-point of modifyColumnNotOwnerErr doesn't work.
And as issues.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the modified column statement (processing backfill data or indexes) return the `NotOwnerErr` in the write-reorg state when the DDL-owner TiDB is down or a network partition occurs

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 5, 2022
@zimulala zimulala changed the title ddl: fix the not owner error, mockNotOwnerErr and failed next key ddl: when executing modify column, fix some issues: returns ErrNotOwner, mock the ErrNotOwner failure, and does not update the cache for the next key Dec 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 6, 2022
@tangenta tangenta changed the title ddl: when executing modify column, fix some issues: returns ErrNotOwner, mock the ErrNotOwner failure, and does not update the cache for the next key ddl: handle ErrNotOwner properly for modify column Dec 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 6, 2022
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Dec 7, 2022

/run-unit-test

@hawkingrei
Copy link
Member

hawkingrei commented Dec 7, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ae5b21f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2022
@ti-chi-bot ti-chi-bot merged commit 2ea253e into pingcap:master Dec 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 7, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [3] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 6 min 20 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 5 min 33 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 5 min 4 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 6 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 35 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 6 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@zimulala zimulala deleted the zimuxia/ctc-not-owner branch December 9, 2022 07:28
wjhuang2016 pushed a commit to wjhuang2016/tidb that referenced this pull request Dec 14, 2022
@zimulala @wjhuang2016
ddl: handle ErrNotOwner properly for modify column (pingcap#39645)
426410f 
close pingcap#39643, close pingcap#39644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

5 participants

@zimulala @ti-chi-bot @hawkingrei @sre-bot @tangenta