Skip to content

sysvar: fix inconsistency in setting password validation sysvars#39584

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
CbcWestwolf:fix_validate_password
Dec 3, 2022
Merged

sysvar: fix inconsistency in setting password validation sysvars#39584
ti-chi-bot merged 3 commits intopingcap:masterfrom
CbcWestwolf:fix_validate_password

Conversation

@CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Dec 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #38928

Also merge the PR in tidb-test

Problem Summary:

Since sysvars for password validation satisfy length >= number_count + special_char_count + 2 * mixed_case_count, altering the latter 3 sysvars may also alter length

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2022
@CbcWestwolf
Copy link
Member Author

CbcWestwolf commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2031

@CbcWestwolf CbcWestwolf marked this pull request as ready for review December 2, 2022 11:32
@CbcWestwolf CbcWestwolf requested a review from a team as a code owner December 2, 2022 11:32
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2022
@hawkingrei hawkingrei requested a review from bb7133 December 2, 2022 15:47
bb7133
bb7133 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Dec 3, 2022

/merge

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 3, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e55a478

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 3, 2022
@CbcWestwolf
Copy link
Member Author

CbcWestwolf commented Dec 3, 2022

/run-mysql-test tidb-test=pr/2031

@ti-chi-bot ti-chi-bot merged commit 0b1096e into pingcap:master Dec 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 4 min 13 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 38, total 40 24 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 11 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 9 min 42 sec Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 52 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tangenta tangenta added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 12, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 12, 2022

In response to a cherrypick label: new pull request created to branch release-6.5: #39845.

ti-chi-bot added a commit that referenced this pull request Dec 14, 2022
@ti-chi-bot
sysvar: fix inconsistency in setting password validation sysvars (#39584
c23cd80 
) (#39845)

ref #38928
@CbcWestwolf CbcWestwolf mentioned this pull request Jan 3, 2023
Merged
12 tasks
@hawkingrei hawkingrei mentioned this pull request Jan 4, 2023
Closed
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 4, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CbcWestwolf @ti-chi-bot @bb7133 @sre-bot @hawkingrei @tangenta