Skip to content

ttl,ddl: disable ttl for fk and temp table#39581

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
YangKeao:disable-ttl-for-fk-and-temp-table
Dec 2, 2022
Merged

ttl,ddl: disable ttl for fk and temp table#39581
ti-chi-bot merged 3 commits intopingcap:masterfrom
YangKeao:disable-ttl-for-fk-and-temp-table

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 2, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #39364, close #39351

Problem Summary:

TTL table cannot be a temporary table and cannot be referenced as the parent of foreign key.

What is changed and how it works?

Add several checks for alter ttl, alter forign key, and create table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 2, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 2, 2022

/run-check-issue-triage-complete

hawkingrei
hawkingrei reviewed Dec 2, 2022
View reviewed changes
@YangKeao
disable ttl for fk and temp table
5f4c300 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the disable-ttl-for-fk-and-temp-table branch from 388e48d to 5f4c300 Compare December 2, 2022 06:36
@YangKeao YangKeao requested a review from hawkingrei December 2, 2022 07:13
@YangKeao YangKeao added affects-6.5 This bug affects the 6.5.x(LTS) versions. sig/sql-infra SIG: SQL Infra labels Dec 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2022
@xhebox
Copy link
Contributor

xhebox commented Dec 2, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5f4c300

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 2, 2022
@ti-chi-bot ti-chi-bot merged commit d045b41 into pingcap:master Dec 2, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022

In response to a cherrypick label: new pull request created: #39598.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2022
Merged
4 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 12 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 13 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 38, total 40 26 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 40 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 48 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 34 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot added a commit that referenced this pull request Dec 19, 2022
@ti-chi-bot
ttl,ddl: disable ttl for fk and temp table (#39581) (#39598)
61ee84e 
close #39351, close #39364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees

No one assigned

Labels

affects-6.5 This bug affects the 6.5.x(LTS) versions. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Forbid creating/altering a temporary table with TTL options TTL Table should not be reference as a parent table by a foreign key

5 participants

@YangKeao @ti-chi-bot @xhebox @sre-bot @hawkingrei