Skip to content

planner: prohibit StreamAgg with group keys for TiFlash (#39547)#39567

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39547-to-release-6.1
Closed

planner: prohibit StreamAgg with group keys for TiFlash (#39547)#39567
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39547-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 1, 2022

This is an automated cherry-pick of #39547

StreamAgg with group keys is not supported on TiFlash.

Issue Number: close #39266

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fixdb @ti-chi-bot
This is an automated cherry-pick of pingcap#39547
ec2f372 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 1, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Dec 1, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 5, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 29, 2022

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test ec2f372 link true /test unit-test
idc-jenkins-ci-tidb/check_dev ec2f372 link true /test check-dev
idc-jenkins-ci-tidb/build ec2f372 link true /test build
idc-jenkins-ci-tidb/check_dev_2 ec2f372 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test ec2f372 link true /test mysql-test
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fixdb
Copy link
Contributor

fixdb commented Jan 10, 2023

Replace this PR in favor of #40482

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 11, 2023

@ti-chi-bot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrysan
Copy link
Contributor

chrysan commented Jan 12, 2023

Close it since it's duplicated with #40482

@chrysan chrysan closed this Jan 12, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Feb 8, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39547-to-release-6.1 branch April 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fixdb fixdb

Labels

cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @fixdb @chrysan @VelocityLight