Skip to content

planner: prohibit StreamAgg with group keys for TiFlash (#39547)#40482

Merged
ti-chi-bot merged 3 commits intopingcap:release-6.1from
fixdb:tiflash_streamagg_6.x
Jan 11, 2023
Merged

planner: prohibit StreamAgg with group keys for TiFlash (#39547)#40482
ti-chi-bot merged 3 commits intopingcap:release-6.1from
fixdb:tiflash_streamagg_6.x

Conversation

@fixdb
Copy link
Contributor

@fixdb fixdb commented Jan 10, 2023 •
edited
Loading

This is an automated cherry-pick of #39547

StreamAgg with group keys is not supported on TiFlash.

Issue Number: close #39266

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fixdb @ti-chi-bot
This is an automated cherry-pick of pingcap#39547
ec2f372 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 10, 2023
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2023
@fixdb fixdb changed the title Tiflash streamagg 6.x planner: prohibit StreamAgg with group keys for TiFlash (#39547) Jan 10, 2023
@fixdb fixdb mentioned this pull request Jan 10, 2023
Closed
12 tasks
@fixdb fixdb force-pushed the tiflash_streamagg_6.x branch from 6630598 to 60e2d6c Compare January 10, 2023 23:03
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2023
@chrysan
Copy link
Contributor

chrysan commented Jan 11, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 60e2d6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2023

@fixdb: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

elsa0520
elsa0520 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2023

@elsa0520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AilinKid
Copy link
Contributor

AilinKid commented Jan 11, 2023

/run-unit-test

1 similar comment
@fixdb
Copy link
Contributor Author

fixdb commented Jan 11, 2023

/run-unit-test

@fixdb
Copy link
Contributor Author

fixdb commented Jan 11, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit df459f1 into pingcap:release-6.1 Jan 11, 2023
@fixdb fixdb deleted the tiflash_streamagg_6.x branch January 11, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elsa0520 elsa0520 elsa0520 approved these changes

+2 more reviewers

@chrysan chrysan chrysan approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fixdb @ti-chi-bot @chrysan @AilinKid @xuyifangreeneyes @elsa0520 @VelocityLight