Skip to content

util: use one logger#39176

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
xhebox:rework_0
Nov 16, 2022
Merged

util: use one logger#39176
ti-chi-bot merged 5 commits intopingcap:masterfrom
xhebox:rework_0

Conversation

@xhebox
Copy link
Contributor

@xhebox xhebox commented Nov 16, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close #38941

Problem Summary: Check the issue. Use one logger.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Check the issue.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix broken log rotation of grpc

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Nov 16, 2022
@xhebox
util: use one logger
8d01377 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: go tidy
c0b5309 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: update bazel
ac01f61 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2022
@xhebox
*: remove useless test
bfb5b93 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Nov 16, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bfb5b93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2022
@xhebox
Copy link
Contributor Author

xhebox commented Nov 16, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit ba35a37 into pingcap:master Nov 16, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

In response to a cherrypick label: new pull request created: #39184.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 16, 2022
@xhebox @ti-chi-bot
This is an automated cherry-pick of pingcap#39176
7e46455 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

In response to a cherrypick label: new pull request created: #39185.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 16, 2022
@xhebox @ti-chi-bot
This is an automated cherry-pick of pingcap#39176
4cca8a9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

In response to a cherrypick label: new pull request created: #39186.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 16, 2022
@xhebox @ti-chi-bot
This is an automated cherry-pick of pingcap#39176
d66fa66 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Nov 16, 2022
@ti-chi-bot
util: use one logger (#39176) (#39186)
b2c62c6 
close #38941
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 44 min Existing failure
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 38, total 39 24 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 7 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot added a commit that referenced this pull request Nov 16, 2022
@ti-chi-bot
util: use one logger (#39176) (#39185)
cfec3aa 
close #38941
@xhebox xhebox deleted the rework_0 branch April 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The gRPC log is output to the wrong file

5 participants

@xhebox @ti-chi-bot @hawkingrei @sre-bot @tangenta