br: modify collate.newCollationEnabled according to the config of the cluster#39173
br: modify collate.newCollationEnabled according to the config of the cluster#39173ti-chi-bot merged 9 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
f95350e to
8e77fed
Compare
|
Due to the cycle import caused by importing the |
8e77fed to
f8945ab
Compare
|
/run-check-dev-2 |
|
/component br |
|
@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
f8945ab to
c6d947c
Compare
c6d947c to
1bbd49c
Compare
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 1bbd49cc88fc41906c6d486bd4277e50a7db8798 |
|
/run-check-dev-2 |
1 similar comment
|
/run-check-dev-2 |
|
/run-unit-test |
|
/run-check-dev-2 |
|
/run-check-dev-2 |
|
/run-check-dev-2 |
081f8f2 to
54875a6
Compare
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
54875a6 to
40e3788
Compare
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 40e3788 |
|
In response to a cherrypick label: new pull request created: #39319. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #39150
Problem Summary:
The
collate.newCollationEnabledvariable is set to 1 when the collate package is initialized. When using this package, this value is not modified according to the config of the TiDB cluster (i.e.,new_collations_enabled_on_first_bootstrap).As a result, the user sets
new_collations_enabled_on_first_bootstraptofalsein the TiDB cluster, and it is still treated astruewhen br is executed.What is changed and how it works?
Modify
collate.newCollationEnabledaccording to the config of the cluster.Check List
Tests
Side effects
Documentation
Manual test
new_collations_enabled_on_first_bootstrap: false.create table books (id bigint auto_increment,name varchar(64), primary key (id)) CHARSET utf8mb4 COLLATE utf8mb4_0900_ai_ci;new_collations_enabled_on_first_bootstrap: false.Release note
Please refer to Release Notes Language Style Guide to write a quality release note.