Skip to content

DDL: Fix bug that TiFlash replica unavailable after add partition with small probability#39170

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
hehechen:fix_bug
Nov 16, 2022
Merged

DDL: Fix bug that TiFlash replica unavailable after add partition with small probability#39170
ti-chi-bot merged 5 commits intopingcap:masterfrom
hehechen:fix_bug

Conversation

@hehechen
Copy link
Contributor

@hehechen hehechen commented Nov 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39171

Problem Summary:
There is a small probability that TiFlash replica unavailable after add partition.
refreshTiFlashTicker don't check if logical table is available, so if a partition has been added in AddingDefinitions of tableInfo, and have not been added in AvailablePartitionIDs, and refreshTiFlashTicker is executed at this time, this new added partition will be considered unavailable, so it will get TiFlash replica progress and then update available of the logical table.

What is changed and how it works?

Check if logical table is available in refreshTiFlashTicker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hehechen added 2 commits November 15, 2022 23:35
fix tiflash replica unavailable after add partition
801a7a4 
Signed-off-by: hehechen <chentongli@pingcap.com>
add ut
3de37a9 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Nov 16, 2022
@hehechen
Copy link
Contributor Author

hehechen commented Nov 16, 2022

/cc @breezewish @CalvinNeo @crazycs520

@hehechen
Copy link
Contributor Author

hehechen commented Nov 16, 2022

/cc @windtalker

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2022
fix lint
5787b34 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Nov 16, 2022
windtalker
windtalker approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2022
@breezewish
Copy link
Member

breezewish commented Nov 16, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5f23ff7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2022
@ti-chi-bot ti-chi-bot merged commit 7f83ec4 into pingcap:master Nov 16, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

In response to a cherrypick label: new pull request created: #39195.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 16, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#39170
b910df0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 1, success 27, total 28 8 min 36 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 45 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 12 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 21 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 23 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 35 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

CalvinNeo
CalvinNeo reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ti-chi-bot added a commit that referenced this pull request Jan 16, 2023
@ti-chi-bot
DDL: Fix bug that TiFlash replica unavailable after add partition wit…
67705e6 
…h small probability (#39170) (#39195)

close #39171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@breezewish breezewish breezewish approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

+1 more reviewer

@CalvinNeo CalvinNeo CalvinNeo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There is a small probability that TiFlash replica unavailable after add partition

6 participants

@hehechen @ti-chi-bot @breezewish @sre-bot @windtalker @CalvinNeo