Skip to content

executor: split hashjoin into workers(part2)#39079

Merged
ti-chi-bot merged 10 commits intopingcap:masterfrom
XuHuaiyu:split_hashjoin_part2
Nov 11, 2022
Merged

executor: split hashjoin into workers(part2)#39079
ti-chi-bot merged 10 commits intopingcap:masterfrom
XuHuaiyu:split_hashjoin_part2

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Nov 11, 2022

What problem does this PR solve?

Issue Number: refer #39061

Problem Summary:

What is changed and how it works?

Modify the probeWorker attribute to []probeWorker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Nov 11, 2022 

executor/benchmark_test.go:935:4: e.probeWorker undefined (type *HashJoinExec has no field or method probeWorker)

executor/benchmark_test.go:937:5: e.probeWorker undefined (type *HashJoinExec has no field or method probeWorker)

wshwsh12
wshwsh12 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI. Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0f203c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 11, 2022

/rebuild

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0cf2b61

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 11, 2022

/run-check_dev

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 11, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit b5e1f7a into pingcap:master Nov 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 18 min New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 37, total 39 22 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 5 min 54 sec Existing failure
idc-jenkins-ci-tidb/integration-compatibility-test 🔴 failed 1, success 0, total 1 1 min 44 sec Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Dec 8, 2022
@XuHuaiyu
Revert "executor: split hashjoin into workers(part2) (pingcap#39079)"
263b6bc 
This reverts commit b5e1f7a.
XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Dec 26, 2022
@XuHuaiyu
Revert "executor: split hashjoin into workers(part2) (pingcap#39079)"
77edf82 
This reverts commit b5e1f7a.
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 26, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XuHuaiyu @ti-chi-bot @hawkingrei @sre-bot @guo-shaoge @wshwsh12