Skip to content

util: fix panic cause by nil plan in memeory usage alarm#38727

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
mengxin9014:mx/fixPanicByNilPlanInMemoryUsageAlarm
Oct 31, 2022
Merged

util: fix panic cause by nil plan in memeory usage alarm#38727
ti-chi-bot merged 7 commits intopingcap:masterfrom
mengxin9014:mx/fixPanicByNilPlanInMemoryUsageAlarm

Conversation

@mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Oct 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number:
close #38701

Problem Summary:

What is changed and how it works?

Fix panic cause by nil plan in memeory usage alarm.
add a label to indicate whether the plan can be analyzed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2022
@mengxin9014 mengxin9014 changed the title fix panic cause by nil plan in memeory usage alarm util: fix panic cause by nil plan in memeory usage alarm Oct 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 31, 2022
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Oct 31, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 31, 2022
@wshwsh12
Copy link
Contributor

wshwsh12 commented Oct 31, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7dac6da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 31, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 31, 2022
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Oct 31, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9f28ac9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 31, 2022
@ti-chi-bot ti-chi-bot merged commit a151383 into pingcap:master Oct 31, 2022
@mengxin9014 mengxin9014 deleted the mx/fixPanicByNilPlanInMemoryUsageAlarm branch October 31, 2022 10:03
@sre-bot
Copy link
Contributor

sre-bot commented Oct 31, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 24 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 39 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 58 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 48 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 38 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei mentioned this pull request Nov 1, 2022
Closed
mengxin9014 added a commit to mengxin9014/tidb that referenced this pull request Nov 12, 2022
@mengxin9014
Revert "util: fix panic cause by nil plan in memeory usage alarm (pin…
62e860a 
…gcap#38727)"

This reverts commit a151383.
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 13, 2022
@mengxin9014 @ti-chi-bot
Revert "util: fix panic cause by nil plan in memeory usage alarm (pin…
6599ad8 
…gcap#38727)"

This reverts commit a151383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tidb occurred panic: interface conversion: interface is nil, not core.Plan when memory usage was growing quickly

6 participants

@mengxin9014 @ti-chi-bot @wshwsh12 @XuHuaiyu @sre-bot @hawkingrei