Skip to content

dump: fix dump large tables will timeout#38540

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
lance6716:fix-dump-timeout
Oct 20, 2022
Merged

dump: fix dump large tables will timeout#38540
ti-chi-bot merged 6 commits intopingcap:masterfrom
lance6716:fix-dump-timeout

Conversation

@lance6716
Copy link
Contributor

@lance6716 lance6716 commented Oct 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #36549

Problem Summary:

What is changed and how it works?

always allow retry for meta connection

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2022
@lance6716 lance6716 changed the title [WIP]dump: fix dump large tables will timeout dump: fix dump large tables will timeout Oct 19, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@lance6716
remove unused files
592556c 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix remove wrong files
a846c4d 
Signed-off-by: lance6716 <lance6716@gmail.com>
lichunzhu
lichunzhu approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@lance6716
Copy link
Contributor Author

lance6716 commented Oct 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a846c4d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@ti-chi-bot ti-chi-bot merged commit 5b0ae14 into pingcap:master Oct 20, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #38558.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 20, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#38540
b6fe725 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

In response to a cherrypick label: new pull request created: #38559.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 20, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#38540
fb45293 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@sre-bot
Copy link
Contributor

sre-bot commented Oct 20, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 26 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 31 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot added a commit that referenced this pull request Jan 10, 2023
@ti-chi-bot
dump: fix dump large tables will timeout (#38540) (#38559)
2fa990e 
close #36549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@okJiang okJiang okJiang approved these changes

+1 more reviewer

@lichunzhu lichunzhu lichunzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dumpling may get blocked when taskChan is full and cause connection timeout

5 participants

@lance6716 @ti-chi-bot @sre-bot @lichunzhu @okJiang