Skip to content

planner: process over-optimization and skip plan-cache in some cases to avoid disaster plans#38537

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
qw4990:fix-38533
Oct 20, 2022
Merged

planner: process over-optimization and skip plan-cache in some cases to avoid disaster plans#38537
ti-chi-bot merged 5 commits intopingcap:masterfrom
qw4990:fix-38533

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Oct 19, 2022

What problem does this PR solve?

Issue Number: close #38533

Problem Summary: planner: process over-optimization and skip plan-cache in some cases to avoid disaster plans

What is changed and how it works?

planner: process over-optimization and skip plan-cache in some cases to avoid disaster plans

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from Reminiscent October 19, 2022 03:13
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2022
@qw4990 qw4990 requested a review from chrysan October 19, 2022 06:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Oct 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d43b0e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@ti-chi-bot ti-chi-bot merged commit 7806b7c into pingcap:master Oct 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 20, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 25 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 0 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 1 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 11 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 31 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@qw4990 qw4990 added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Dec 28, 2022
@qw4990 qw4990 mentioned this pull request Dec 28, 2022
Closed
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2022

In response to a cherrypick label: new pull request created to branch release-6.4: #40211.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2022

In response to a cherrypick label: new pull request created to branch release-6.3: #40212.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 28, 2022
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#38537
33f4165 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 28, 2022
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#38537
b00efa7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2022

In response to a cherrypick label: new pull request created to branch release-6.1: #40213.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 28, 2022
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#38537
a231484 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2022

In response to a cherrypick label: new pull request created to branch release-6.2: #40214.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 28, 2022
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#38537
137f641 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@qw4990 qw4990 mentioned this pull request Mar 28, 2023
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Mar 28, 2023
@ti-chi-bot
planner: process over-optimization and skip plan-cache in some cases …
135aafd 
…to avoid disaster plans (#38537) (#40213)

close #38533
ti-chi-bot pushed a commit that referenced this pull request Mar 28, 2023
@qw4990
planner: process over-optimization and skip plan-cache in some cases …
89c0b5a 
…to avoid disaster plans (#38537) (#42627)

close #38533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrysan chrysan Awaiting requested review from chrysan

2 more reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

epic/plan-cache needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

planner: unexpected FullScan when using prepared plan cache

5 participants

@qw4990 @ti-chi-bot @sre-bot @xuyifangreeneyes @Reminiscent