expression: fix the issue that extracting day_microsecond/day_second/day_minute/day_hour from Time type emits wrong result (#36297)#36335
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
|
@zanmato1984 you're already a collaborator in bot's repo. |
cherry-pick #36297 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36335After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #34998
Problem Summary:
There was once an issue #9716 about
extract(day_microsecond)not recognizing the heading day portion, and it was later fixed by #21601. But that PR introduced another problem aboutextract(day_microsecond)on regular time data. What happens under the hood is:day_microsecondguides the type infer to interpret the time data as datetime through implicit cast;What is changed and how it works?
For regular datetime/timestamp/time types, let
extract(day_microsecond/second/minute/hour)interpret it as time.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.