Skip to content

expression: fix the issue that extracting day_microsecond/day_second/day_minute/day_hour from Time type emits wrong result (#36297)#36335

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.1from
ti-srebot:release-5.1-51b8884feaae
Closed

expression: fix the issue that extracting day_microsecond/day_second/day_minute/day_hour from Time type emits wrong result (#36297)#36335
ti-srebot wants to merge 1 commit intopingcap:release-5.1from
ti-srebot:release-5.1-51b8884feaae

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 19, 2022

cherry-pick #36297 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36335

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36335:release-5.1-51b8884feaae

What problem does this PR solve?

Issue Number: close #34998

Problem Summary:

There was once an issue #9716 about extract(day_microsecond) not recognizing the heading day portion, and it was later fixed by #21601. But that PR introduced another problem about extract(day_microsecond) on regular time data. What happens under the hood is:

  1. Unit day_microsecond guides the type infer to interpret the time data as datetime through implicit cast;
  2. When doing implicit cast from time to datetime, current timestamp is padded to the original time as the date portion of the resulting datetime value;
  3. The time portion is messed up with the newly padded date portion, esp. for values larger than 24 hour or negative.

What is changed and how it works?

For regular datetime/timestamp/time types, let extract(day_microsecond/second/minute/hour) interpret it as time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that extracting day_microsecond/day_second/day_minute/day_hour from time type emits wrong result.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 19, 2022
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.1-cherry-pick type/bugfix This PR fixes a bug. labels Jul 19, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 19, 2022
@ti-srebot ti-srebot added this to the v5.1.4 milestone Jul 19, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2022
@ti-srebot
Copy link
Contributor Author

@zanmato1984 you're already a collaborator in bot's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/5.1-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants