expression: fix compatibility of extract day_time unit functions#21601
Merged
ti-srebot merged 7 commits intopingcap:masterfrom Dec 11, 2020
Merged
expression: fix compatibility of extract day_time unit functions#21601ti-srebot merged 7 commits intopingcap:masterfrom
ti-srebot merged 7 commits intopingcap:masterfrom
Conversation
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Contributor
Author
|
/cc @ichn-hu |
Contributor
Author
|
/cc @XuHuaiyu |
Contributor
Author
|
./run-all-tests |
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/rebuild |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
Closed
XuHuaiyu
reviewed
Dec 11, 2020
| return int64(d.Hour())*10000 + int64(d.Minute())*100 + int64(d.Second()), nil | ||
| case "HOUR_MINUTE": | ||
| return int64(d.Hour())*100 + int64(d.Minute()), nil | ||
| case "DAY_MICROSECOND": |
Contributor
There was a problem hiding this comment.
Add some test in ExtractDurationNum
Contributor
Author
There was a problem hiding this comment.
select extract(day_second from "01 12:12:12") arrives here.
ti-srebot
approved these changes
Dec 11, 2020
Contributor
Author
|
/merge |
Contributor
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 11, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #21676 |
qw4990
pushed a commit
that referenced
this pull request
Jan 27, 2021
12 tasks
This was referenced Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lzmhhh123 lzmhhh123@gmail.com
What problem does this PR solve?
Issue Number: close #9716
Related changes
Check List
Tests
Side effects
Release note