Skip to content

Revert "planner: fix the wrong cost formula of MPPExchanger"#35707

Merged
ti-chi-bot merged 2 commits intomasterfrom
revert-35438-fix-mpp-netcost
Jun 24, 2022
Merged

Revert "planner: fix the wrong cost formula of MPPExchanger"#35707
ti-chi-bot merged 2 commits intomasterfrom
revert-35438-fix-mpp-netcost

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 24, 2022 •
edited
Loading

Issue Number: ref #35240

Reverts #35438

Only fix this wrong formula on model ver2.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/48e39c3bbb96dfeb3ac7f912d6dda607bc1bd637

fixdb
fixdb approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2022

@fixdb: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

+1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2022
@AilinKid
Copy link
Contributor

AilinKid commented Jun 24, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 48e39c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 24, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 3f8df8c into master Jun 24, 2022
@ti-chi-bot ti-chi-bot deleted the revert-35438-fix-mpp-netcost branch June 24, 2022 06:22
@qw4990 qw4990 mentioned this pull request Jun 24, 2022
Closed
morgo added a commit to morgo/tidb that referenced this pull request Jun 24, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into add-bootstrap-sql
a0769dc 
* upstream/master: (38 commits)
  planner: disable collate clause support for enum or set column (pingcap#35684)
  *: Provide a util to "pause" session in uint test (pingcap#35529)
  ddl: implement the core for multi-schema change (pingcap#35429)
  parser: XXXDatabaseStmt now use CIStr for DB name (pingcap#35668)
  *: remove real tikv test on github actions (pingcap#35710)
  lightning: support disable scheduler by key range (pingcap#34130)
  Revert "planner: fix the wrong cost formula of MPPExchanger" (pingcap#35707)
  ddl, owner: refresh ddl sequence cache after becoming the owner (pingcap#35516)
  store/copr: fix tiflash integration test by disable paging on tiflash (pingcap#35674)
  planner: new cost formula for IndexJoin (pingcap#35671)
  BR: fix backup ranges total time summary log (pingcap#35552)
  raw_restore: fix the issue that raw restore rewrite the t prefix keys (pingcap#35641)
  table: fix cannot find the temp table when it's created in a transaction (pingcap#35663)
  metrics: replace histogram with counter for  DistSQLCoprCache (pingcap#35514)
  *: enable exportloopref  (pingcap#35680)
  types: fix bad error message for numeric conversion issue#32744 (pingcap#34047)
  *: enable ineffassign (pingcap#35670)
  config, sysvar: map `max-server-connections` to `max_connections` (pingcap#35453)
  *: enable durationcheck for nogo linter (pingcap#35661)
  *: fix issue of cast string as time is incompatible with MySQL (pingcap#35455)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fixdb fixdb fixdb approved these changes

@AilinKid AilinKid AilinKid approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qw4990 @ti-chi-bot @sre-bot @AilinKid @fixdb @time-and-fate