ddl: fix the partial-count collection for ddl reorg encountering errors halfway#34165
Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom Apr 22, 2022
Merged
ddl: fix the partial-count collection for ddl reorg encountering errors halfway#34165ti-chi-bot merged 4 commits intopingcap:masterfrom
ti-chi-bot merged 4 commits intopingcap:masterfrom
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/41b6f375ac6e197ce5b1eec0c7aef5dc7d1093ef |
hawkingrei
approved these changes
Apr 22, 2022
Member
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: ee412bf |
Contributor
TiDB MergeCI notify
|
espresso98
pushed a commit
to espresso98/tidb
that referenced
this pull request
Apr 25, 2022
…rs halfway (pingcap#34165) ref pingcap#32306, close pingcap#34164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #34164 ref #32306
Problem Summary:
What is changed and how it works?
We need to record the partial count and warning count down at breakpoint.
This breakpoint maybe caused by txn fail caused by some write conflict, network, and so on.
Nevertheless, we still need to collect these partial count down before we return the error in this ddl round.
Because, in next round of ddl, it will start from a brand new startKey which is persisted at the last ddl round.
For cancel type, we don't care about the counts like we don't even care about the job. We can ignore it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.