Skip to content

plugin: revert #27269 for test#34139

Merged
ti-chi-bot merged 1 commit intopingcap:release-5.4-20220308from
bb7133:bb7133/revert_27269
Apr 21, 2022
Merged

plugin: revert #27269 for test#34139
ti-chi-bot merged 1 commit intopingcap:release-5.4-20220308from
bb7133:bb7133/revert_27269

Conversation

@bb7133
Copy link
Member

@bb7133 bb7133 commented Apr 20, 2022 •
edited
Loading

This PR reverts #27269 for release-5.4-20220308, in which 'logging the SQL twice on success' is not expected. You can treat it as a hot patch.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@bb7133 bb7133 changed the title Revert #27269 for test plugin: revert #27269 for test Apr 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fe3c55f565f133f70b198b85111e3b306c2a7535

@bb7133
Copy link
Member Author

bb7133 commented Apr 21, 2022

/run-check-title

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 21, 2022
@djshow832
Copy link
Contributor

djshow832 commented Apr 21, 2022

Could you add some description? Test what? What's the current problem?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2022
@bb7133
Copy link
Member Author

bb7133 commented Apr 21, 2022

Could you add some description? Test what? What's the current problem?

I've updated the title and description to make things more clear.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2022
@djshow832
Copy link
Contributor

djshow832 commented Apr 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fe3c55f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2022
@ti-chi-bot ti-chi-bot merged commit 5c597dc into pingcap:release-5.4-20220308 Apr 21, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
@tiancaiamao tiancaiamao deleted the bb7133/revert_27269 branch May 7, 2022 08:39
bb7133 added a commit to bb7133/tidb that referenced this pull request May 13, 2022
@bb7133
plugin: revert pingcap#27269 for test (pingcap#34139)
d66225c
ti-chi-bot pushed a commit that referenced this pull request May 13, 2022
@bb7133
plugin: revert #27269 for test (#34139) (#34638)
4f91bc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

7 participants

@bb7133 @ti-chi-bot @sre-bot @djshow832 @lcwangchao @purelind @zhouqiang-cl