Skip to content

util: track the memory usage of rowPtrs in sortedRowContainer#34128

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
wshwsh12:track-rowptrs-for-sort
Apr 21, 2022
Merged

util: track the memory usage of rowPtrs in sortedRowContainer#34128
ti-chi-bot merged 5 commits intopingcap:masterfrom
wshwsh12:track-rowptrs-for-sort

Conversation

@wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Apr 20, 2022 •
edited by XuHuaiyu
Loading

What problem does this PR solve?

Issue Number: ref #33877
close #35632
Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • guo-shaoge

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 20, 2022
@wshwsh12 wshwsh12 mentioned this pull request Apr 20, 2022
Closed
10 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/50a8db69a07b792a9de572b146ff3894b2d785f2

@wshwsh12 wshwsh12 requested review from XuHuaiyu and guo-shaoge April 20, 2022 09:45
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2022
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Apr 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a3c49bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2022
@ti-chi-bot ti-chi-bot merged commit 9478a6b into pingcap:master Apr 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 6 min 42 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 23 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

espresso98 pushed a commit to espresso98/tidb that referenced this pull request Apr 25, 2022
@wshwsh12 @espresso98
util: track the memory usage of rowPtrs in sortedRowContainer (pingca…
2e26d54 
…p#34128)

ref pingcap#33877
@wshwsh12 wshwsh12 mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Track the memory usage of rowPtrs in SortedRowContainer

5 participants

@wshwsh12 @ti-chi-bot @sre-bot @guo-shaoge @XuHuaiyu