Skip to content

lightning_web: mute the alert#33390

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
3pointer:alert
Apr 21, 2022
Merged

lightning_web: mute the alert#33390
ti-chi-bot merged 7 commits intopingcap:masterfrom
3pointer:alert

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 24, 2022

What problem does this PR solve?

Problem Summary: github reports security issue, this PR try to mute it.

What is changed and how it works?

update pakcage-lock.json

Check List

Tests

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lonng
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
lonng
lonng approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2022
@ngaut
Copy link
Member

ngaut commented Apr 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 618c265

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f4f2fe4c7b32f00c4919c1d952ee0ee8cd0b98e6

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Apr 12, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Apr 12, 2022

/run-mysql-test

@hawkingrei
Copy link
Member

hawkingrei commented Apr 12, 2022

@3pointer Please fix the linter.

@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label Apr 12, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Apr 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9c94c94

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@3pointer
Copy link
Contributor Author

3pointer commented Apr 13, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@3pointer
Copy link
Contributor Author

3pointer commented Apr 13, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Apr 21, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Apr 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2022

@3pointer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a1031d0 into pingcap:master Apr 21, 2022
espresso98 pushed a commit to espresso98/tidb that referenced this pull request Apr 25, 2022
@3pointer @espresso98
lightning_web: mute the alert (pingcap#33390)
bedd3e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngaut ngaut ngaut approved these changes

+1 more reviewer

@lonng lonng lonng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@3pointer @ti-chi-bot @ngaut @sre-bot @hawkingrei @lonng