Skip to content

statistics/handle: migrate test-infra to testify#32135

Merged
tisonkun merged 1 commit intopingcap:masterfrom
tisonkun:issue-28127
Feb 7, 2022
Merged

statistics/handle: migrate test-infra to testify#32135
tisonkun merged 1 commit intopingcap:masterfrom
tisonkun:issue-28127

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Feb 7, 2022

Signed-off-by: tison wander4096@gmail.com

Issue Number: close #28127 close #28126 close #27141 close #30006

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022

/cc @hawkingrei @xhebox @mmyj

cc @feitian124 I'm taking over your work to move forward the migrate effort.

@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022

/check-issue-triage-complete

@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022

/check-issue-triage-complete

@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 457e39fe8aada8302fe6ae78c1fb78e9d395277b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022

/run-unit-test

@tisonkun
statistics/handle: migrate test-infra to testify
5afe09d 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 7, 2022 •
edited
Loading

/merge

Above force push fix a t.Skip incidentally omitted.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5afe09d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 7, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5afe09dfa8eafb2d02cea560d157e39a8bb434a6

@tisonkun tisonkun merged commit 3c777c4 into pingcap:master Feb 7, 2022
@tisonkun tisonkun deleted the issue-28127 branch February 7, 2022 13:31
@feitian124
Copy link
Contributor

feitian124 commented Feb 8, 2022

ok, thanks. sorry for my slow progress recently.

@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 8, 2022

@feitian124 never mind. Wish you and your family a nice day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@mmyj mmyj Awaiting requested review from mmyj

@xhebox xhebox Awaiting requested review from xhebox

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

6 participants

@tisonkun @ti-chi-bot @sre-bot @feitian124 @JmPotato @hawkingrei