Skip to content

statistics: migrate test-infra to testify for handle/update_test.go#30006

Closed
feitian124 wants to merge 19 commits intopingcap:masterfrom
feitian124:issue-28127
Closed

statistics: migrate test-infra to testify for handle/update_test.go#30006
feitian124 wants to merge 19 commits intopingcap:masterfrom
feitian124:issue-28127

Conversation

@feitian124
Copy link
Contributor

@feitian124 feitian124 commented Nov 22, 2021

What problem does this PR solve?

Issue Number: close #28127

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2021
@feitian124 feitian124 force-pushed the issue-28127 branch 2 times, most recently from 13ea37b to 6ec1b66 Compare November 23, 2021 02:28
@feitian124
Copy link
Contributor Author

feitian124 commented Nov 23, 2021

/run-check_dev_2

1 similar comment
@feitian124
Copy link
Contributor Author

feitian124 commented Nov 23, 2021

/run-check_dev_2

@tisonkun
Copy link
Contributor

tisonkun commented Nov 23, 2021

/cc @rebelice @time-and-fate

@tisonkun
Copy link
Contributor

tisonkun commented Nov 23, 2021

/cc @xuyifangreeneyes

tisonkun
tisonkun reviewed Nov 26, 2021
View reviewed changes
statistics/handle/handle_test.go Outdated
Comment on lines 100 to 135
Copy link
Contributor

@tisonkun tisonkun Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move this block to main_test.go

@tisonkun
Copy link
Contributor

tisonkun commented Dec 7, 2021

@feitian124 @time-and-fate @rebelice any updates?

@feitian124
Copy link
Contributor Author

feitian124 commented Dec 7, 2021 •
edited
Loading

@tisonkun working on it. try add parallal run following original suite.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021

@feitian124: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Dec 26, 2021

@feitian124 I think in a previous discussion #30869 we decided to run all tests in serial. You can update the code and let's move forward.

@feitian124
Revert "add Parallel run"
5495315 
This reverts commit 3bf6a73.
@tisonkun
Copy link
Contributor

tisonkun commented Jan 24, 2022

@feitian124 are you still working on this PR?

@feitian124
Copy link
Contributor Author

feitian124 commented Jan 24, 2022 •
edited
Loading

i was busy on some personal affairs, i am a father now。
will arrange sometime and finish it in a few days。

@tisonkun tisonkun mentioned this pull request Feb 7, 2022
Merged
@tisonkun tisonkun added the type/enhancement The issue or PR belongs to an enhancement. label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun left review comments

@rebelice rebelice Awaiting requested review from rebelice

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for statistics/handle/update_test.go

3 participants

@feitian124 @ti-chi-bot @tisonkun