Skip to content

planner: unify the argument of range functions to use SessionCtx instead of StatementContext#29999

Merged
ti-chi-bot merged 8 commits intopingcap:masterfrom
qw4990:range-arg-refactor
Nov 23, 2021
Merged

planner: unify the argument of range functions to use SessionCtx instead of StatementContext#29999
ti-chi-bot merged 8 commits intopingcap:masterfrom
qw4990:range-arg-refactor

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 22, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

No logical change, just refactors:

  1. unify the argument of range functions to use SessionCtx instead of StatementContext; (SessionCtx has more info than StmtCtx and most other components are using SessionCtx too)
  2. merge two similar functions IsPoint and IsPointNullable into one.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2021
@qw4990 qw4990 changed the title planner: update planner: unify the argument of range functions to use SessionCtx instead of StatementContext Nov 22, 2021
@qw4990 qw4990 requested review from Reminiscent and xuyifangreeneyes and removed request for xuyifangreeneyes November 22, 2021 09:06
@qw4990
Copy link
Contributor Author

qw4990 commented Nov 22, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2021
@qw4990 qw4990 requested a review from winoros November 22, 2021 13:02
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Nov 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9314b68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2021
@ti-chi-bot ti-chi-bot merged commit d15ca2a into pingcap:master Nov 23, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 3, 2021

/cherry-pick release-5.3

@qw4990 qw4990 added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Dec 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 3, 2021

/cherry-pick release-5.3

@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Open
1 task
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 3, 2021
@qw4990 @ti-srebot
cherry pick pingcap#29999 to release-5.3
85f4715 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 3, 2021

cherry pick to release-5.3 in PR #30376

@qw4990 qw4990 mentioned this pull request Dec 7, 2021
Merged
1 task
Yisaer added a commit to Yisaer/tidb that referenced this pull request Dec 7, 2021
@Yisaer
Merge pull request #1 from qw4990/sctx
dae2887 
planner: unify the argument of range functions to use SessionCtx instead of StatementContext (pingcap#29999)
qw4990 added a commit to qw4990/tidb that referenced this pull request Dec 8, 2021
@qw4990
planner: unify the argument of range functions to use SessionCtx in…
93907a7 
…stead of `StatementContext` (pingcap#29999)
qw4990 added a commit to qw4990/tidb that referenced this pull request Dec 10, 2021
@qw4990
planner: unify the argument of range functions to use SessionCtx in…
cc52a0a 
…stead of `StatementContext` (pingcap#29999)
@qw4990 qw4990 mentioned this pull request Dec 10, 2021
Merged
1 task
zhouqiang-cl pushed a commit that referenced this pull request Dec 10, 2021
@qw4990 @Yisaer
planner: regard NULL as point when accessing composite index (#30244) (…
6605146 
…#30614)

* planner: unify the argument of range functions to use `SessionCtx` instead of `StatementContext` (#29999)

Signed-off-by: yisaer <disxiaofei@163.com>

Co-authored-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros Awaiting requested review from winoros

2 more reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qw4990 @ti-chi-bot @ti-srebot @xuyifangreeneyes @Reminiscent